stremio-linux-shell: init at 1.0.0-beta.13#468728
stremio-linux-shell: init at 1.0.0-beta.13#468728thunze wants to merge 1 commit intoNixOS:masterfrom
Conversation
8a7be91 to
8ee52a8
Compare
|
packaged the refactor/gtk4 branch here: https://gitlab.com/fazzi/nixohess/-/blob/main/parts/pkgs/packages/stremio-linux-shell-rewrite/package.nix broken on wayland for me right now tho, entire CEF ui is upside down haha |
Awesome, thanks! I'll probably update this PR once we have a tag or the branch gets merged into |
Refer: NixOS/nixpkgs#468728 - bump nixpkgs
|
Thanks. I had to add |
8ee52a8 to
332d9d7
Compare
|
I have tested the following version ([stremio-linux-shell: init at 1.0.0-beta.13]. However, launching this newer version of stremio still causes my PC to crash. I am then forced to reboot my PC to get back into NixOS unstable. |
332d9d7 to
a6be976
Compare
I can't reproduce this locally, unfortunately, but I've now patched the paths to
I tried to fix the libxkbcommon error you were seeing (see above), but I'm afraid I'm going to need a bit more information to investigate the "crash/hang" you're reporting. What makes you think it's related to the packaging of stremio, specifically? |
|
@thunze I only encounter a complete system hang/unrecoverable crash when launching stremio. I don't encounter crashes or instability with any other package I use in NixOS unstable. The stremio crash only occurs between 33% and 50% of the launches, not all the time. Here is my system info: And here is the output of RUST_BACKTRACE=full stremio when I get lucky and my PC does not crash: |
a6be976 to
e7fb8c7
Compare
Does this still happen with e7fb8c7 or the change described in #468728 (comment)? |
|
@thunze |
|
Well, I spoke of success too soon. I successfully launched stremio twice. Third time my PC crashed again. So still unresolved, unfortunately..... |
Checked with the new version, and seems to work 👍 |
|
This is the output without the libxkbcommon changes, btw: (maybe it's a X vs Wayland problem? I am using X) |
|
I am currently planning to drop qt5 webengine in #480196. I didn't see there was a PR for the new linux client open already. Feel free to request my review once upstream decides which technologies to use and i can review the nix aspects of the PR. I don't feel confident testing stremio itself, but if a review here is what it takes to move forward with the qt5 webengine removal, so be it. |
Thanks, will do! Upstream hasn't really changed much since I opened the PR (at least on |
e7fb8c7 to
9c59c5f
Compare
8bdfe15 to
7b39701
Compare
7b39701 to
f06f7b6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
c5b6403 to
3994a25
Compare
Co-authored-by: Fazzi <[email protected]>
3994a25 to
8a0debe
Compare
|
I have tested the following version ([stremio-linux-shell: init at 1.0.0-beta.13]. However, just like my previous experience on January 14 (see my comment above) launching this newer version of stremio still causes my PC to crash. I am then forced to reboot my PC to get back into NixOS unstable. I am referring to 8a0debe And here is the output of RUST_BACKTRACE=full stremio when I get lucky and my PC does not crash:
|
Sorry, I'm unable to reproduce this and there's nothing in the provided logs that indicates a packaging issue that could cause the problem you're experiencing. (In fact, I've seen all of these log lines on my end as well.) If this is a system-level crash, please provide kernel logs ( Without a reproducible case or crash logs, I'm afraid there isn’t anything actionable here. |
|
I packaged this for Debian, and I had to introduce several patches, I don't know exactly what is the cause in your case, but might be one of the patches that I had to make can give you a clue: https://salsa.debian.org/mendezr/stremio-gtk/-/tree/master/debian/patches?ref_type=heads |
|
wow that's a lot of patches, surely at least some of those should be upstream? |
Good point. I shall go over them and see if the more critical gets accepted. |
This PR adds stremio-linux-shell, the new client for Stremio on Linux.
Given that
qt5.qtwebenginewill be dropped in the near future due to being vulnerable, I think now is a good time to drop the oldstremiopackage that still depends onqt5.qtwebengine(I'll do that in a separate PR) and initstremio-linux-shellas a replacement (at least on Linux). Looking at upstream, it unfortunately doesn't look like there's a suitable replacement for darwin yet.Historically, stremio-linux-shell has seen a few different rewrites, each using different underlying technologies, so at first we held off on packaging it in nixpkgs. However, since I originally opened this PR,
mainand the tagged releases have been pretty stable.I based this derivation on @fxzzi's derivation for an earlier version of stremio-linux-shell.
Closes #437992, #489227
For reference, here's the part of the old PR description that used to track the different rewrites of stremio-linux-shell:
Old description
This PR adds stremio-linux-shell, the new client for Stremio on Linux.
It currently packages rewrite number 2 on the below list of rewrites that are out there, following tag
v1.0.0-beta.13. I'll try to keep this list updated as upstream continues to work on the app.v1.0.0-beta.13)mainThings done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.