Skip to content

dnscontrol: 4.27.1 -> 4.28.2#468036

Merged
zowoq merged 1 commit intoNixOS:masterfrom
GaetanLepage:update/dnscontrol
Dec 8, 2025
Merged

dnscontrol: 4.27.1 -> 4.28.2#468036
zowoq merged 1 commit intoNixOS:masterfrom
GaetanLepage:update/dnscontrol

Conversation

@GaetanLepage
Copy link
Copy Markdown
Contributor

@GaetanLepage GaetanLepage commented Dec 5, 2025 •
edited
Loading

Things done

Diff: StackExchange/dnscontrol@v4.27.1...v4.28.2
Changelogs:

NOTE: 4.28.0 (and 4.28.1) is a pre-release for now. Let's wait for it to get marked as stable (https://github.com/StackExchange/dnscontrol/releases/tag/v4.28.0).

cc @SuperSandro2000 @zowoq

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Dec 5, 2025
@zowoq
Copy link
Copy Markdown
Contributor

zowoq commented Dec 5, 2025

https://github.com/StackExchange/dnscontrol/releases/tag/v4.28.0
We're using the Github feature to mark this as a "pre-release". It will be labeled as non-production ready. It will be marked as production ready in a few weeks, or we may just skip to a .1 release if bugs are found.

@GaetanLepage GaetanLepage marked this pull request as draft December 5, 2025 08:48
zowoq
zowoq reviewed Dec 5, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 5, 2025
@GaetanLepage

This comment was marked as outdated.

Sign in to view
@GaetanLepage GaetanLepage changed the title dnscontrol: 4.27.1 -> 4.28.0 dnscontrol: 4.27.1 -> 4.28.1 Dec 5, 2025
@GaetanLepage GaetanLepage marked this pull request as ready for review December 5, 2025 18:34
@nixpkgs-ci nixpkgs-ci bot requested review from SuperSandro2000 and zowoq December 5, 2025 18:38
@GaetanLepage

This comment was marked as outdated.

Sign in to view
@GaetanLepage GaetanLepage marked this pull request as draft December 5, 2025 18:46
@GaetanLepage GaetanLepage changed the title dnscontrol: 4.27.1 -> 4.28.1 dnscontrol: 4.27.1 -> 4.28.2 Dec 8, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

GaetanLepage commented Dec 8, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 468036
Commit: 0874a60a68f664ec7e9317360fce47d72efff2a4

x86_64-linux

✅ 1 package built:
  • dnscontrol

aarch64-linux

✅ 1 package built:
  • dnscontrol

x86_64-darwin

✅ 1 package built:
  • dnscontrol

aarch64-darwin

✅ 1 package built:
  • dnscontrol

SuperSandro2000
SuperSandro2000 approved these changes Dec 8, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/StackExchange/dnscontrol/releases/tag/v4.28.2

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review December 8, 2025 19:12
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Dec 8, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

GaetanLepage commented Dec 8, 2025

https://github.com/StackExchange/dnscontrol/releases/tag/v4.28.2

It seems like they are implying that this one is more or less stable, right?

@zowoq zowoq added this pull request to the merge queue Dec 8, 2025
Merged via the queue into NixOS:master with commit b575694 Dec 8, 2025
31 of 34 checks passed
@GaetanLepage GaetanLepage deleted the update/dnscontrol branch December 8, 2025 22:58
@GaetanLepage GaetanLepage added the backport release-25.11 Backport PR automatically label Dec 8, 2025
@nixpkgs-ci
Copy link
Copy Markdown
Contributor

nixpkgs-ci bot commented Dec 8, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 8, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 8, 2025
@GaetanLepage
Copy link
Copy Markdown
Contributor Author

GaetanLepage commented Dec 8, 2025

@zowoq, would this be eligible for backport?

@zowoq
Copy link
Copy Markdown
Contributor

zowoq commented Dec 8, 2025

Backporting should be fine.

@leona-ya leona-ya mentioned this pull request Feb 4, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@zowoq zowoq Awaiting requested review from zowoq

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaetanLepage @zowoq @SuperSandro2000