Skip to content

xterm: 403 -> 404#466746

Merged
fabianhjr merged 1 commit intoNixOS:stagingfrom
trofi:xterm-update
Dec 10, 2025
Merged

xterm: 403 -> 404#466746
fabianhjr merged 1 commit intoNixOS:stagingfrom
trofi:xterm-update

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 1, 2025 •
edited
Loading

Changes: https://invisible-island.net/xterm/xterm.log.html#xterm_404

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from NeQuissimus December 1, 2025 06:35
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 1, 2025
Yarny0
Yarny0 approved these changes Dec 5, 2025
View reviewed changes
Copy link
Contributor

@Yarny0 Yarny0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review per https://github.com/NixOS/nixpkgs/tree/418468ac9527e799809c900eda37cbff999199b6/pkgs#package-updates

Reviewed points

Everything below tested on x86_64-linux, after cherry-picking the commit onto current nixos-unstable:

  • package name fits guidelines
  • package version fits guidelines
  • package builds on x86_64-linux
  • executables tested on ARCHITECTURE
  • any change of upstream are verified (none)
  • the motives for any special packaging choices are documented (none)
  • all depending packages build
  • patches have a comment describing either the upstream URL or a reason why the patch wasn't upstreamed (none)
  • patches that are remotely available are fetched rather than vendored (none)

More:

  • license still matches upstream
  • xterm.tests build/pass
  • quick test: xterm works fine, respects color settings in .Xresources

@nixos-discourse
Copy link

nixos-discourse commented Dec 5, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2678

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 5, 2025
@fabianhjr fabianhjr added this pull request to the merge queue Dec 10, 2025
Merged via the queue into NixOS:staging with commit 58064ea Dec 10, 2025
34 of 36 checks passed
@trofi trofi deleted the xterm-update branch December 10, 2025 10:01
@rhelmot
Copy link
Contributor

rhelmot commented Dec 14, 2025

I am getting errors trying to build this:

structuredAttrs is enabled

trying ftp://ftp.invisible-island.net/xterm/xterm-404.tgz
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
curl: (67) Access denied: 550
Warning: Problem (retrying all errors). Will retry in 1 second. 3 retries left.
  0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
curl: (67) Access denied: 550
Warning: Problem (retrying all errors). Will retry in 2 seconds. 2 retries 
Warning: left.
  0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
curl: (67) Access denied: 550
Warning: Problem (retrying all errors). Will retry in 4 seconds. 1 retry left.
  0     0   0     0   0     0     0     0  --:--:-- --:--:-- --:--:--     0
curl: (67) Access denied: 550
error: cannot download xterm-404.tgz from any mirror

the invisible-island homepage claims that ftp service was ended in 2023. Will submit a PR pointing to the http archives.

@rhelmot
Copy link
Contributor

rhelmot commented Dec 14, 2025

#470602

@trofi
Copy link
Contributor Author

trofi commented Dec 14, 2025

Maybe it's the other mirror that would normally have worked. Don't know why the log does not show it. I certainly had xterm-404 fetched and built locally a few times:

$ ls -d1 /nix/store/*xterm-404
/nix/store/2jxps69zh0kay80s1m1812pyr4isx4qz-xterm-404
/nix/store/5aagwriy8wni016sq89zw8myq1qrv9xi-xterm-404
/nix/store/879hl4y6p0zqzffchsibbkla9x0vl5md-xterm-404
/nix/store/a1q102mdyl73icvc1cxzm36h2bf9mk76-xterm-404
/nix/store/bz8skh1l2v3jhvb9zxv8nspzysaz010x-xterm-404
/nix/store/jp3sbyhy55wgbs5wrq402bfcam7936rh-xterm-404
/nix/store/mix8ihx8pvxpbxgcqd4s59za5qy26cm2-xterm-404
/nix/store/plkaih37gvmixfd329ig36z6n2s5hnkn-xterm-404

@trofi
Copy link
Contributor Author

trofi commented Dec 14, 2025

I'm also confused why fetcher does not try another https:// fallback. Maybe because of 550 error.

@trofi
Copy link
Contributor Author

trofi commented Dec 14, 2025

I suspect structuredAttrs has something to do with it as urls is now an array urls=([0]="ftp://ftp.invisible-island.net/xterm/xterm-403.tgz" [1]="https://invisible-mirror.net/archives/xterm/xterm-403.tgz") and fetcher uses it as for url in $urls; do (not ${URLs[@]} or similar).

@trofi
Copy link
Contributor Author

trofi commented Dec 14, 2025

Proposed the fetchurl fix as:

@trofi trofi mentioned this pull request Dec 14, 2025
Merged
13 tasks
@Yarny0 Yarny0 mentioned this pull request Dec 18, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

1 more reviewer

@Yarny0 Yarny0 Yarny0 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trofi @nixos-discourse @rhelmot @Yarny0 @fabianhjr