Skip to content

ceph: remove unused dependency from httpcore#466339

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:ceph
Nov 29, 2025
Merged

ceph: remove unused dependency from httpcore#466339
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:ceph

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Nov 29, 2025 •
edited
Loading

This fixes the build of ceph and can be reverted once #462435 reaches master.

cc @limwa

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda
ceph: remove unused dependency from httpcore
ea34eac 
This fixes the build of ceph and can be reverted once
NixOS#462435 reaches master.
@dotlambda dotlambda added the backport release-25.11 Backport PR automatically label Nov 29, 2025
@dotlambda dotlambda mentioned this pull request Nov 29, 2025
Closed
3 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". labels Nov 29, 2025
@dotlambda
Copy link
Member Author

dotlambda commented Nov 29, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 466339 --additional-package ceph.passthru.tests
Commit: ea34eac61bf8d9463b03d74bd9559f9f3d759972

x86_64-linux

✅ 18 packages built:
  • ceph (ceph-dev)
  • ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph-dev.client, ceph.client)
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • ceph.passthru.tests.ceph-multi-node
  • ceph.passthru.tests.ceph-single-node
  • ceph.passthru.tests.ceph-single-node-bluestore
  • ceph.passthru.tests.ceph-single-node-bluestore-dmcrypt
  • qemu_full
  • qemu_full.debug
  • qemu_full.doc
  • qemu_full.ga
  • sambaFull (samba4Full)
  • sambaFull.dev (samba4Full.dev)
  • sambaFull.man (samba4Full.man)

@dotlambda dotlambda added this pull request to the merge queue Nov 29, 2025
limwa
limwa approved these changes Nov 29, 2025
View reviewed changes
Copy link
Contributor

@limwa limwa left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Also, I don't know what's usually done in these situations, but should a PR be made to staging and staging-25.11 that reverts these changes? Will you take care of that?

EDIT: I have a nixpkgs-review running for systems other than x86_64-linux and it appears that ceph and qemu_full still don't build in those systems... aarch64-linux, for instance

EDIT2: nvm, it's a problem with scipy, all good!

Merged via the queue into NixOS:master with commit d838d63 Nov 29, 2025
35 of 38 checks passed
@dotlambda dotlambda deleted the ceph branch November 29, 2025 20:16
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 29, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Nov 29, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 29, 2025
@dotlambda
Copy link
Member Author

dotlambda commented Nov 29, 2025

should a PR be made to staging and staging-25.11 that reverts these changes? Will you take care of that?

Yes and yes. But I'll wait for master to be merged into staging first.

@limwa
Copy link
Contributor

limwa commented Nov 29, 2025

Yes and yes. But I'll wait for master to be merged into staging first.

Perfect!

@limwa
Copy link
Contributor

limwa commented Nov 29, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 466339
Commit: ea34eac61bf8d9463b03d74bd9559f9f3d759972 (subsequent changes)
Merge: 7dabe7f314104f220ceef563c6ac6cc242a10f0b

Logs: https://github.com/limwa/nixpkgs-review-gha/actions/runs/19787851750

x86_64-linux

✅ 14 packages built:
  • ceph (ceph-dev)
  • ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph-dev.client, ceph.client)
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • qemu_full
  • qemu_full.debug
  • qemu_full.doc
  • qemu_full.ga
  • sambaFull (samba4Full)
  • sambaFull.dev (samba4Full.dev)
  • sambaFull.man (samba4Full.man)

aarch64-linux

❌ 10 packages failed to build:
  • ceph (ceph-dev)
  • ceph-client (ceph-client.client, ceph-client.dev, ceph-client.doc, ceph-client.lib, ceph-client.man, ceph-dev.client, ceph.client)
  • ceph-csi
  • ceph.dev (ceph-dev.dev)
  • ceph.doc (ceph-dev.doc)
  • libceph (ceph.lib, libceph.client, libceph.dev, libceph.doc, libceph.lib, libceph.man)
  • ceph.man (ceph-dev.man)
  • qemu_full
  • qemu_full.doc
  • qemu_full.ga

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

This was referenced Nov 30, 2025
Merged
Open
@nixos-discourse
Copy link

nixos-discourse commented Dec 2, 2025

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/25-11-upgrade-stuck-on-python3-11-aioquic-1-2-0-build-failure/72657/4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adevress adevress Awaiting requested review from adevress

@benaryorg benaryorg Awaiting requested review from benaryorg

@johanot johanot Awaiting requested review from johanot

@krav krav Awaiting requested review from krav

@nh2 nh2 Awaiting requested review from nh2

1 more reviewer

@limwa limwa limwa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dotlambda @limwa @nixos-discourse