jetbrains: pycharm/idea unified builds; deprecate writerside & aqua#466331
jetbrains: pycharm/idea unified builds; deprecate writerside & aqua#466331MattSturgeon merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
requested review from
GenericNerdyUsername,
Mic92,
RemcoSchrijver,
baldo,
dritter,
edwtjo,
gytis-ivaskevicius,
jamesward,
leona-ya,
raphaelr,
rasendubi,
thiagokokada,
tymscar and
zlepper
nixpkgs-ci
bot
added
10.rebuild-linux: 11-100
theCapypara
removed request for
GenericNerdyUsername,
Mic92,
RemcoSchrijver,
baldo,
dritter,
jamesward,
leona-ya,
raphaelr,
rasendubi,
thiagokokada and
zlepper
nixpkgs-ci
bot
added
the
12.approved-by: package-maintainer
|
IMK we can also drop the old packages now and throw a message where they can be found now. This is unstable, there is no reason to keep upstream unmaintained packages for another year. In that case a release note would be good tho. The more interesting question is what to do with 25.11. I think the best solution would be to use the current state of this PR for that. Then we still offer supported versions to our users without forcing them to move. I haven't yet tested this PR, but the changes in itself look good. |
|
In that case I would then change the text to say "removed in 26.05" again, we merge this, backport it and then open a PR to throw for 26.05 / unstable, am I understanding correctly? |
|
That or alternatively we can do seperate PRs and just target |
theCapypara
force-pushed
the
jetbrains-oss
branch
from
e835a58 to
b502fff
Compare
|
I think doing it via backport is probably the least messy solution, so I just changed the wording in here to say 26.05 and will open a follow-up PR once this is merged. |
leona-ya
left a comment
leona-ya
left a comment
There was a problem hiding this comment.
This looks good to me. Thank you very much :)
nixpkgs-ci
bot
added
12.approvals: 3+
|
We decided to wait for merging #463570 first for one last update of the community-bin packages. |
theCapypara
force-pushed
the
jetbrains-oss
branch
from
b502fff to
2843a9a
Compare
|
I think this has been open long enough to gather feedback. Everyone seems happy. Additionally, it's blocking follow-up work, so I'll merge it now. Thanks everyone! |
This comment has been minimized.
This comment has been minimized.
|
The backport should be doable when #470841 is merged. Do we need to create it manually then or can the bot retriggered by re-adding the label here then? |
You can do either. Removing & re-adding the label will trigger the bot again. Sometimes it's neater to create a single backport PR that cherry-picks all relevant commits from the respective |
This comment has been minimized.
This comment has been minimized.
|
…from cachyos, revert 17fb3b0 @ desktop.nix * rename package `idea-ultimate` to `idea` following NixOS/nixpkgs#466331 @ jetbrains.nix @ modules $ nix flake update .?submodules=1 $ git submodule update --remote
6 participants
This replaces #412971. It also relates to #426427 and fixes #412715.
pycharm-community-srcandidea-community-srcare renamed topycharm-ossandidea-osswith a warning for the old aliases also informing users of the changes Jetbrains made. I checked with how the Open Source versions are supposed to be built, they are built just like Community was.pycharm-community-binandidea-community-binare not updated anymore and now raise a warningpycharm-professionalandidea-ultimateare renamed topycharmandideawith a warningwritersideandaquanow throw a warning when used, to be removed in 26.05To be done for 26.05 (should do this shortly before next release):
pycharm-community-src,idea-community-src,pycharm-professional,idea-ultimatepycharm-community-bin,idea-community-bin, remove thecommunityentries from theides.jsonand remove thepycharm-communityandidea-communityaliaseswriterside,aquaand their entries from theides.json