Skip to content

Revert build host target platform deprecation on master#46517

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
srhb:revert-build-host-target-platform-deprecation-master
Sep 12, 2018
Merged

Revert build host target platform deprecation on master#46517
Ericson2314 merged 1 commit intoNixOS:masterfrom
srhb:revert-build-host-target-platform-deprecation-master

Conversation

@srhb
Copy link
Contributor

@srhb srhb commented Sep 11, 2018

Motivation for this change

Unblocks nixpkgs.tarball
#46059 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@srhb srhb requested a review from Ericson2314 September 11, 2018 10:09
@srhb srhb requested a review from nbp as a code owner September 11, 2018 10:09
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Sep 11, 2018
@srhb srhb force-pushed the revert-build-host-target-platform-deprecation-master branch from 492de5b to 2a6e4ae Compare September 11, 2018 11:25
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: changelog This PR adds or changes release notes labels Sep 11, 2018
@Ericson2314 Ericson2314 merged commit 34e3502 into NixOS:master Sep 12, 2018
@Ericson2314 Ericson2314 mentioned this pull request Sep 12, 2018
Merged
9 tasks
@Ericson2314
Copy link
Member

Ericson2314 commented Sep 12, 2018

Sorry I took so long to look at these.

@Artturin Artturin mentioned this pull request Jan 9, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@nbp nbp Awaiting requested review from nbp

Assignees

No one assigned

Labels

8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@srhb @Ericson2314 @GrahamcOfBorg