Skip to content

openboardview: 9.95.0 -> 9.95.2; unbreak CI#465066

Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom
felixsinger:pkgs/openboardview/update
Nov 29, 2025
Merged

openboardview: 9.95.0 -> 9.95.2; unbreak CI#465066
Aleksanaa merged 1 commit intoNixOS:masterfrom
felixsinger:pkgs/openboardview/update

Conversation

@felixsinger
Copy link
Member

@felixsinger felixsinger commented Nov 25, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@felixsinger felixsinger added the backport release-25.11 Backport PR automatically label Nov 25, 2025
@felixsinger
Copy link
Member Author

Also unbreaks the build on hydra.

@nixpkgs-ci nixpkgs-ci bot requested a review from k3a November 25, 2025 21:48
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 25, 2025
@k3a
Copy link
Contributor

k3a commented Nov 25, 2025

I already have a PR #453563 - it additionally watches GitHub Release tags in the updater script

@k3a k3a closed this Nov 25, 2025
@felixsinger felixsinger deleted the pkgs/openboardview/update branch November 25, 2025 22:13
@felixsinger felixsinger restored the pkgs/openboardview/update branch November 26, 2025 14:34
@felixsinger felixsinger reopened this Nov 26, 2025
@felixsinger felixsinger force-pushed the pkgs/openboardview/update branch from 623f35d to 69394c3 Compare November 26, 2025 14:35
@felixsinger
Copy link
Member Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 26, 2025

@felixsinger wants to merge this PR.

Requirements to merge this PR with @NixOS/nixpkgs-merge-bot merge:

  • ✅ PR targets a development branch.
  • ✅ PR touches only files of packages in pkgs/by-name/.
  • ❌ PR is at least one of:
    • ⬜ Approved by a committer.
    • ⬜ Backported via label.
    • ⬜ Opened by a committer.
    • ⬜ Opened by r-ryantm.
  • ✅ felixsinger is a member of @NixOS/nixpkgs-maintainers.
  • ❌ felixsinger is a maintainer of all touched packages.

Tip

Maintainers eligible to merge are:

  • k3a

❌ Pull Request could not be merged (#305350)

@felixsinger felixsinger changed the title openboardview: 9.95.0 -> 9.95.2 openboardview: 9.95.0 -> 9.95.2; unbreak CI Nov 26, 2025
Copy link
Contributor

@k3a k3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this. Btw I've re-learned that .90. versions are alpha and .95. versions are beta and it is actually possible that they won't use pre-releases ever again. You were right, probably not worth making the update script in the near term, sorry for the yesterday.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 27, 2025
@k3a k3a requested a review from Aleksanaa November 27, 2025 14:18
@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 465066
Commit: 69394c3b5d60b8cc5ae27c4c8234f6ed11e2e2d1 (subsequent changes)
Merge: 914c98d89fc4f15f6ed3518172a3ad7b8c4b66a2

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/19761036994


x86_64-linux

✅ 1 package built:
  • openboardview

aarch64-linux

✅ 1 package built:
  • openboardview

x86_64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • openboardview

Error logs: `x86_64-darwin`
openboardview
  407 |   _LIBCPP_HIDE_FROM_ABI path(const path& __p) : __pn_(__p.__pn_) {}
      |                         ^
/nix/build/nix-8486-1004395974/source/src/openboardview/confparse.cpp:508:12: error: '~path' is unavailable: introduced in macOS 10.15
  508 |                                                 auto nfn = filepath;
      |                                                      ^
/nix/store/1mzb0lbliqa5spskrmwj6qxv2gpi9gwx-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:434:25: note: '~path' has been explicitly marked unavailable here
  434 |   _LIBCPP_HIDE_FROM_ABI ~path() = default;
      |                         ^
/nix/build/nix-8486-1004395974/source/src/openboardview/confparse.cpp:509:11: error: 'operator+=' is unavailable: introduced in macOS 10.15
  509 |                                                 nfn += "~";
      |                                                     ^
/nix/store/1mzb0lbliqa5spskrmwj6qxv2gpi9gwx-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:575:31: note: 'operator+=' has been explicitly marked unavailable here
  575 |   _LIBCPP_HIDE_FROM_ABI path& operator+=(const value_type* __x) {
      |                               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [src/openboardview/CMakeFiles/openboardview.dir/build.make:102: src/openboardview/CMakeFiles/openboardview.dir/confparse.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:364: src/openboardview/CMakeFiles/openboardview.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

aarch64-darwin (sandbox = relaxed)

❌ 1 package failed to build:
  • openboardview

Error logs: `aarch64-darwin`
openboardview
  407 |   _LIBCPP_HIDE_FROM_ABI path(const path& __p) : __pn_(__p.__pn_) {}
      |                         ^
/nix/build/nix-9235-250239248/source/src/openboardview/confparse.cpp:508:12: error: '~path' is unavailable: introduced in macOS 10.15
  508 |                                                 auto nfn = filepath;
      |                                                      ^
/nix/store/1a05xixrdmk175drdln3w047x3dxfr7l-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:434:25: note: '~path' has been explicitly marked unavailable here
  434 |   _LIBCPP_HIDE_FROM_ABI ~path() = default;
      |                         ^
/nix/build/nix-9235-250239248/source/src/openboardview/confparse.cpp:509:11: error: 'operator+=' is unavailable: introduced in macOS 10.15
  509 |                                                 nfn += "~";
      |                                                     ^
/nix/store/1a05xixrdmk175drdln3w047x3dxfr7l-libcxx-19.1.2+apple-sdk-15.5/include/c++/v1/__filesystem/path.h:575:31: note: 'operator+=' has been explicitly marked unavailable here
  575 |   _LIBCPP_HIDE_FROM_ABI path& operator+=(const value_type* __x) {
      |                               ^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
make[2]: *** [src/openboardview/CMakeFiles/openboardview.dir/build.make:102: src/openboardview/CMakeFiles/openboardview.dir/confparse.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:364: src/openboardview/CMakeFiles/openboardview.dir/all] Error 2
make: *** [Makefile:156: all] Error 2

Copy link
Contributor

@k3a k3a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this version, you just need to include my patch:

patches = [
    (fetchpatch {
      name = "fix-darwin-build.patch";
      url = "https://github.com/OpenBoardView/OpenBoardView/commit/a1de2e5de908afd83eceed757260f6425314af2e.patch?full_index=1";
      hash = "sha256-DK+K4F0+QGqaoWCyc8AvuIsaiTCqhAG6AsTNg2hegh0=";
    })
  ];

@felixsinger felixsinger force-pushed the pkgs/openboardview/update branch from 69394c3 to ece3cb2 Compare November 28, 2025 16:59
@felixsinger
Copy link
Member Author

For this version, you just need to include my patch:

Great. Thanks!

@Aleksanaa
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 465066
Commit: ece3cb2677484c8f97e0c4560dbcb340b1b1fc4a (subsequent changes)
Merge: eae1b739fe16db6d4a82aba6b24b8a79058c5340

Logs: https://github.com/Aleksanaa/nixpkgs-review-gha/actions/runs/19777440815


x86_64-linux

✅ 1 package built:
  • openboardview

aarch64-linux

✅ 1 package built:
  • openboardview

x86_64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openboardview

aarch64-darwin (sandbox = relaxed)

✅ 1 package built:
  • openboardview

@Aleksanaa Aleksanaa added this pull request to the merge queue Nov 29, 2025
Merged via the queue into NixOS:master with commit 8760d00 Nov 29, 2025
28 of 30 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Nov 29, 2025

Successfully created backport PR for release-25.11:

@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Nov 29, 2025
@felixsinger felixsinger deleted the pkgs/openboardview/update branch November 29, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants