Skip to content

netdata: 2.8.0 -> 2.8.4 #463836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkg20001 merged 1 commit into from
Dec 18, 2025
Merged

netdata: 2.8.0 -> 2.8.4 #463836

mkg20001 merged 1 commit into from
Dec 18, 2025

Conversation

@rhoriguchi
Copy link
Contributor

@rhoriguchi rhoriguchi commented Nov 21, 2025 •
edited
Loading

Built and tested package with these flags:

netdata.override {
  withCloudUi = true;
  withCups = true;
  withDBengine = true;
  withDebug = false;
  withLibbacktrace = false;
  withML = true;
  withNdsudo = true;
  withOtel = false;
  withSystemdJournal = false;
};

netdata.override {
  withCloudUi = false;
  withCups = true;
  withDBengine = false;
  withDebug = false;
  withLibbacktrace = false;
  withML = false;
  withNdsudo = true;
  withOtel = false;
  withSystemdJournal = false;
};

Introduced a bug with #446721, because I've set the bin dir to XXX/sbin, which does not exist.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot requested a review from mkg20001 November 21, 2025 19:26
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Nov 21, 2025
@rhoriguchi rhoriguchi marked this pull request as draft November 22, 2025 17:29
@rhoriguchi rhoriguchi force-pushed the netdata branch 3 times, most recently from 91ea0a7 to 14e83ae Compare November 22, 2025 18:31
@rhoriguchi rhoriguchi mentioned this pull request Nov 22, 2025
Closed
@rhoriguchi rhoriguchi marked this pull request as ready for review November 22, 2025 21:47
@rhoriguchi rhoriguchi changed the title netdata: 2.8.0 -> 2.8.1 netdata: 2.8.0 -> 2.8.2 Dec 3, 2025
@kylemanna
Copy link

kylemanna commented Dec 4, 2025 •
edited
Loading

Ran in to the bug caused by #446721 with systemd-cat-native not being found spamming my logs:

Dec 04 04:33:23 tiny netdata[52436]: /nix/store/94ii2iy850hfmn7jhby1lkmb8i5n87n1-netdata-2.8.0/libexec/netdata/plugins.d/cgroup-name.sh: line 75: systemd-cat-native: command not found

Tested with overrides:

withCloudUi = true;
withIpmi = false;

This PR fixes it

pedorich-n
pedorich-n approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@pedorich-n pedorich-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with

netdataCloud.override {
    withNdsudo = true;
    withIpmi = false;
};

Also this update fixes netdata/netdata#21343 for me.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 4, 2025
@rhoriguchi rhoriguchi changed the title netdata: 2.8.0 -> 2.8.2 netdata: 2.8.0 -> 2.8.3 Dec 16, 2025
@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Dec 16, 2025

I've updated to 2.8.3 if someone wants to test.

@pedorich-n
Copy link
Contributor

pedorich-n commented Dec 17, 2025

Tested again. Still works fine.
Thanks!

@rhoriguchi rhoriguchi changed the title netdata: 2.8.0 -> 2.8.3 netdata: 2.8.0 -> 2.8.4 Dec 17, 2025
@rhoriguchi
Copy link
Contributor Author

rhoriguchi commented Dec 17, 2025

Again a new version 2.8.4

@kylemanna
Copy link

kylemanna commented Dec 18, 2025

Again a new version 2.8.4

Still works for me, thanks!

@mkg20001 anything I can do to help get this reviewed and merge? It fixes a bug discussed earlier.

@mkg20001 mkg20001 added this pull request to the merge queue Dec 18, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Dec 18, 2025
Merged via the queue into NixOS:master with commit 61f37c6 Dec 18, 2025
30 of 33 checks passed
@rhoriguchi rhoriguchi deleted the netdata branch December 18, 2025 11:45
@rhoriguchi rhoriguchi added the backport release-25.11 Backport PR automatically label Dec 19, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Dec 19, 2025

Successfully created backport PR for release-25.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Dec 19, 2025
Merged
@github-actions github-actions bot added the 8.has: port to stable This PR already has a backport to the stable release. label Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkg20001 mkg20001 mkg20001 approved these changes

+1 more reviewer

@pedorich-n pedorich-n pedorich-n approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: port to stable This PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. backport release-25.11 Backport PR automatically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@rhoriguchi @kylemanna @pedorich-n @mkg20001 @elquike