ci/github-script/prepare: fix with missing release- branch#462957
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Nov 18, 2025
Merged
ci/github-script/prepare: fix with missing release- branch#462957wolfgangwalther merged 1 commit intoNixOS:masterfrom
wolfgangwalther merged 1 commit intoNixOS:masterfrom
Conversation
The prepare script is currently failing for staging-25.11 PR's, because it assumes that a release-25.11 exists respectively. This is not the case in the transition phase before branch-off. We can fix this by always including the current target branch in the branches to check for, even if it's not a WIP branch. This means we might check some branches twice, but that's better than erroring out entirely when the branch is in fact correct.
nixpkgs-ci
bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
Contributor
|
Successfully created backport PR for |
github-actions
bot
added
the
8.has: port to stable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prepare script is currently failing for staging-25.11 PR's, because it assumes that a release-25.11 exists respectively. This is not the case in the transition phase before branch-off.
We can fix this by always including the current target branch in the branches to check for, even if it's not a WIP branch. This means we might check some branches twice, but that's better than erroring out entirely when the branch is in fact correct.
One example of this failing is #462514 (review).
Things done
Add a 👍 reaction to pull requests you find important.