Skip to content

apache-orc: 2.1.2 -> 2.2.1#461975

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
GaetanLepage:update/apache-orc
Dec 4, 2025
Merged

apache-orc: 2.1.2 -> 2.2.1#461975
mweinelt merged 1 commit intoNixOS:stagingfrom
GaetanLepage:update/apache-orc

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 15, 2025 •
edited
Loading

Things done

Diff: apache/orc@v2.1.2...v2.2.1
Changelog: https://github.com/apache/orc/releases/tag/v2.2.1

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

github-actions[bot]

This comment was marked as resolved.

Sign in to view

@GaetanLepage GaetanLepage changed the base branch from master to staging-next November 15, 2025 16:54
@nixpkgs-ci nixpkgs-ci bot closed this Nov 15, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Nov 15, 2025
@github-actions github-actions bot dismissed their stale review November 15, 2025 16:55

All good now, thank you!

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 15, 2025
@GaetanLepage
Copy link
Contributor Author

GaetanLepage commented Nov 15, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 461975 --package apache-orc
Commit: c69433f8cdac5f381c34818ec440396ced498336

x86_64-linux

✅ 1 package built:
  • apache-orc

aarch64-linux

✅ 1 package built:
  • apache-orc

x86_64-darwin

✅ 1 package built:
  • apache-orc

aarch64-darwin

✅ 1 package built:
  • apache-orc

@GaetanLepage GaetanLepage mentioned this pull request Nov 15, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 16, 2025
@vcunat
Copy link
Member

vcunat commented Nov 17, 2025

This would break arrow-cpp build if merged by itself right now.

[734/866] Linking CXX executable release/arrow-buffer-test
FAILED: [code=1] release/arrow-buffer-test 
: && /nix/store/vr15iyyykg9zai6fpgvhcgyw7gckl78w-gcc-wrapper-14.3.0/bin/g++ -Wno-noexcept-type -Wno-self-move  -fdiagnostics-color=always  -Wall -fno-semantic-interposition -msse4.2  -O3 -DNDEBUG -O2 -ftree-vectorize -Wl,--
dependency-file=src/arrow/CMakeFiles/arrow-buffer-test.dir/link.d src/arrow/CMakeFiles/arrow-buffer-test.dir/buffer_test.cc.o -o release/arrow-buffer-test  -Wl,-rpath,/build/source/cpp/build/release  release/libarrow_testin
g.so.2000.0.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgmock.so.1.17.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest_main.so.1.17.0  release/libarrow.so.2000.0.0  /nix/store/
xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest.so.1.17.0 && :
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::MergeFromConcreteMessage(google::protobuf::internal::
RepeatedPtrFieldBase const&, google::protobuf::Arena*, void* (*)(google::protobuf::Arena*, void const*))'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::InternalExtend(int, google::protobuf::Arena*)'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `void google::protobuf::internal::RepeatedPtrFieldBase::MergeFrom<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(google::protobuf::internal::RepeatedPtrFieldBase const&, google::protobuf::Arena*)'
collect2: error: ld returned 1 exit status
[735/866] Linking CXX executable release/arrow-array-test
FAILED: [code=1] release/arrow-array-test 
: && /nix/store/vr15iyyykg9zai6fpgvhcgyw7gckl78w-gcc-wrapper-14.3.0/bin/g++ -Wno-noexcept-type -Wno-self-move  -fdiagnostics-color=always  -Wall -fno-semantic-interposition -msse4.2  -O3 -DNDEBUG -O2 -ftree-vectorize -Wl,--dependency-file=src/arrow/CMakeFiles/arrow-array-test.dir/link.d src/arrow/CMakeFiles/arrow-array-test.dir/array/array_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_binary_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_dict_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_list_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_list_view_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_run_end_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_struct_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_union_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/array_view_test.cc.o src/arrow/CMakeFiles/arrow-array-test.dir/array/statistics_test.cc.o -o release/arrow-array-test  -Wl,-rpath,/build/source/cpp/build/release  release/libarrow_testing.so.2000.0.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgmock.so.1.17.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest_main.so.1.17.0  release/libarrow.so.2000.0.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest.so.1.17.0 && :
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::MergeFromConcreteMessage(google::protobuf::internal::RepeatedPtrFieldBase const&, google::protobuf::Arena*, void* (*)(google::protobuf::Arena*, void const*))'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::InternalExtend(int, google::protobuf::Arena*)'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `void google::protobuf::internal::RepeatedPtrFieldBase::MergeFrom<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(google::protobuf::internal::RepeatedPtrFieldBase const&, google::protobuf::Arena*)'
collect2: error: ld returned 1 exit status
[736/866] Linking CXX executable release/arrow-extension-type-test
FAILED: [code=1] release/arrow-extension-type-test 
: && /nix/store/vr15iyyykg9zai6fpgvhcgyw7gckl78w-gcc-wrapper-14.3.0/bin/g++ -Wno-noexcept-type -Wno-self-move  -fdiagnostics-color=always  -Wall -fno-semantic-interposition -msse4.2  -O3 -DNDEBUG -O2 -ftree-vectorize -Wl,--dependency-file=src/arrow/CMakeFiles/arrow-extension-type-test.dir/link.d src/arrow/CMakeFiles/arrow-extension-type-test.dir/extension_type_test.cc.o -o release/arrow-extension-type-test  -Wl,-rpath,/build/source/cpp/build/release  release/libarrow_testing.so.2000.0.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgmock.so.1.17.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest_main.so.1.17.0  release/libarrow.so.2000.0.0  /nix/store/xb65lffrn4fkg2ks6l0nwsnx6qhl9z0k-gtest-1.17.0/lib/libgtest.so.1.17.0 && :
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::MergeFromConcreteMessage(google::protobuf::internal::RepeatedPtrFieldBase const&, google::protobuf::Arena*, void* (*)(google::protobuf::Arena*, void const*))'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `google::protobuf::internal::RepeatedPtrFieldBase::InternalExtend(int, google::protobuf::Arena*)'
/nix/store/dc9vaz50jg7mibk9xvqw5dqv89cxzla3-binutils-2.44/bin/ld: release/libarrow.so.2000.0.0: undefined reference to `void google::protobuf::internal::RepeatedPtrFieldBase::MergeFrom<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >(google::protobuf::internal::RepeatedPtrFieldBase const&, google::protobuf::Arena*)'
collect2: error: ld returned 1 exit status

@tobim
Copy link
Contributor

tobim commented Nov 17, 2025

Yes, we should merge this, #426611, and #461974 together.

@vcunat
Copy link
Member

vcunat commented Nov 17, 2025

OK, all of them together pass for me (x86_64-linux).

@mweinelt mweinelt mentioned this pull request Nov 17, 2025
Merged
13 tasks
@tobim tobim mentioned this pull request Nov 17, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 19, 2025
@GaetanLepage GaetanLepage changed the base branch from staging-next to staging December 3, 2025 22:04
@nixpkgs-ci nixpkgs-ci bot closed this Dec 3, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 3, 2025
@nixpkgs-ci nixpkgs-ci bot requested review from cpcloud and veprbl December 3, 2025 22:14
@vcunat
Copy link
Member

vcunat commented Dec 4, 2025

I suppose this should get rebased to drop the commits which were in other PRs.

@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2025
@nixpkgs-ci nixpkgs-ci bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 4, 2025
@mweinelt mweinelt enabled auto-merge December 4, 2025 23:42
@mweinelt mweinelt added this pull request to the merge queue Dec 4, 2025
Merged via the queue into NixOS:staging with commit 6440817 Dec 4, 2025
26 of 29 checks passed
@GaetanLepage GaetanLepage deleted the update/apache-orc branch December 4, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@mweinelt mweinelt Awaiting requested review from mweinelt

@tobim tobim Awaiting requested review from tobim

@cpcloud cpcloud Awaiting requested review from cpcloud

@veprbl veprbl Awaiting requested review from veprbl

+1 more reviewer

@codgician codgician codgician approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 501-1000 This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@GaetanLepage @vcunat @tobim @codgician @mweinelt