Skip to content

google-cloud-cpp: 2.38.0 -> 2.43.0, modernize#461974

Merged
vcunat merged 2 commits intoNixOS:stagingfrom
GaetanLepage:google-cloud-cpp
Dec 4, 2025
Merged

google-cloud-cpp: 2.38.0 -> 2.43.0, modernize#461974
vcunat merged 2 commits intoNixOS:stagingfrom
GaetanLepage:google-cloud-cpp

Conversation

@GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Nov 15, 2025

Things done

  • google-cloud-cpp: 2.38.0 -> 2.43.0
  • google-cloud-cpp: modernize

Diff: googleapis/google-cloud-cpp@v2.38.0...v2.43.0
Changelog: https://github.com/googleapis/google-cloud-cpp/blob/v2.43.0/CHANGELOG.md

cc @cpcloud

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage GaetanLepage mentioned this pull request Nov 15, 2025
Closed
13 tasks
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". label Nov 15, 2025
@nixpkgs-ci nixpkgs-ci bot requested a review from cpcloud November 15, 2025 16:54
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Nov 15, 2025
@tobim tobim mentioned this pull request Nov 17, 2025
Merged
13 tasks
@mweinelt
Copy link
Member

mweinelt commented Nov 17, 2025

With #426611 and #461975 applied I repeatedly run into

google-cloud-cpp> 99% tests passed, 5 tests failed out of 509
google-cloud-cpp> 
google-cloud-cpp> Total Test time (real) =  18.75 sec
google-cloud-cpp> 
google-cloud-cpp> The following tests FAILED:
google-cloud-cpp>          73 - common_grpc_error_delegate_test (Failed)
google-cloud-cpp>          97 - common_internal_debug_string_status_test (Failed)
google-cloud-cpp>         400 - spanner_client_test (Failed)
google-cloud-cpp>         410 - spanner_internal_connection_impl_test (Subprocess aborted)
google-cloud-cpp>         423 - spanner_internal_status_utils_test (Failed)
google-cloud-cpp> Errors while running CTest

@tobim
Copy link
Contributor

tobim commented Nov 17, 2025 •
edited
Loading

With #426611 and #461975 applied I repeatedly run into

google-cloud-cpp> 99% tests passed, 5 tests failed out of 509
google-cloud-cpp> 
google-cloud-cpp> Total Test time (real) =  18.75 sec
google-cloud-cpp> 
google-cloud-cpp> The following tests FAILED:
google-cloud-cpp>          73 - common_grpc_error_delegate_test (Failed)
google-cloud-cpp>          97 - common_internal_debug_string_status_test (Failed)
google-cloud-cpp>         400 - spanner_client_test (Failed)
google-cloud-cpp>         410 - spanner_internal_connection_impl_test (Subprocess aborted)
google-cloud-cpp>         423 - spanner_internal_status_utils_test (Failed)
google-cloud-cpp> Errors while running CTest

I can't reproduce that.
Edit: x86_86-linux, fwiw.

@tobim tobim mentioned this pull request Nov 17, 2025
Merged
13 tasks
@vcunat vcunat changed the base branch from staging-next to staging December 4, 2025 15:11
@vcunat vcunat added this pull request to the merge queue Dec 4, 2025
@nixpkgs-ci nixpkgs-ci bot closed this Dec 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a manual request Dec 4, 2025
@nixpkgs-ci nixpkgs-ci bot reopened this Dec 4, 2025
@vcunat vcunat added this pull request to the merge queue Dec 4, 2025
Merged via the queue into NixOS:staging with commit 470b9e0 Dec 4, 2025
54 of 58 checks passed
@GaetanLepage GaetanLepage deleted the google-cloud-cpp branch December 4, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cpcloud cpcloud Awaiting requested review from cpcloud

@mweinelt mweinelt Awaiting requested review from mweinelt

Assignees

No one assigned

Labels

2.status: merge-bot eligible This PR can be merged by commenting "@NixOS/nixpkgs-merge-bot merge". 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 1001-2500 This PR causes many rebuilds on Linux and should target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GaetanLepage @mweinelt @tobim @vcunat