Skip to content

Comments

habitat: 0.32.2 -> 0.62.0#46138

Closed
boj wants to merge 1 commit intoNixOS:masterfrom
boj:habitat-upgrade
Closed

habitat: 0.32.2 -> 0.62.0#46138
boj wants to merge 1 commit intoNixOS:masterfrom
boj:habitat-upgrade

Conversation

@boj
Copy link

@boj boj commented Sep 6, 2018 •
edited
Loading

Motivation for this change

The current version in the repo is a year out of date.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The cargo test doesn't pass for reasons that I don't understand, so it is currently commented out.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Sep 6, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 6, 2018

@GrahamcOfBorg build habitat

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 6, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: habitat

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 6, 2018

Failure on x86_64-darwin (full log)

Attempted: habitat

Partial log (click to expand)

          clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation)


error: aborting due to previous error

error: Could not compile `hab`.

To learn more, run the command again with --verbose.
builder for '/nix/store/01gxpa53wwck33h1pwmpnj508441jc1r-habitat-0.62.0.drv' failed with exit code 101
error: build of '/nix/store/01gxpa53wwck33h1pwmpnj508441jc1r-habitat-0.62.0.drv' failed

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 6, 2018

Success on x86_64-linux (full log)

Attempted: habitat

Partial log (click to expand)

Running cargo test
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
shrinking /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin/hab
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin
patching script interpreter paths in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
checking for references to /build in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0...
/nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0

@GrahamcOfBorg GrahamcOfBorg added 8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Sep 7, 2018
@boj
Copy link
Author

boj commented Sep 7, 2018

I removed the darwin architecture since I have no way to test it myself.

@symphorien symphorien mentioned this pull request Sep 8, 2018
Merged
9 tasks
@Mic92
Copy link
Member

Mic92 commented Sep 17, 2018

@GrahamcOfBorg build habitat

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 17, 2018

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: habitat

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 17, 2018

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: habitat

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

GrahamcOfBorg commented Sep 17, 2018

Success on x86_64-linux (full log)

Attempted: habitat

Partial log (click to expand)

Running cargo test
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
shrinking /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin/hab
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0/bin
patching script interpreter paths in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0
checking for references to /build in /nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0...
/nix/store/vvmcb1i8bz3rfvs5q9b7q428l5q99sa5-habitat-0.62.0

@boj
Copy link
Author

boj commented Sep 25, 2018

@Mic92 Is there anything in particular I need to do to this to get it merged?

Mic92
Mic92 reviewed Sep 25, 2018
View reviewed changes
pkgs/applications/networking/cluster/habitat/default.nix
runHook preCheck
echo "Running cargo test"
cargo test --package hab
# cargo test --package hab
Copy link
Member

@Mic92 Mic92 Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a comment why this was disabled.
I also rather would use doCheck=false.

Mic92
Mic92 reviewed Sep 25, 2018
View reviewed changes
pkgs/applications/networking/cluster/habitat/default.nix
cargoDepsCopy=$(stripHash $(basename $cargoDeps))
chmod -R +w "$cargoDepsCopy"
mkdir -p .cargo
cat >.cargo/config <<-EOF
Copy link
Member

@Mic92 Mic92 Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fortunately we where able to get rid of this in #46362

Can you rebase this package on staging?

ryantm
ryantm requested changes Feb 24, 2019
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Mic92's comments.

@boj
Copy link
Author

boj commented Feb 25, 2019

I cannot get to this right now.

@boj boj closed this Feb 25, 2019
@boj boj mentioned this pull request Jun 14, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mic92 Mic92 Mic92 left review comments

@ryantm ryantm ryantm requested changes

Assignees

No one assigned

Labels

8.has: clean-up This PR removes packages or removes other cruft 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@boj @Mic92 @GrahamcOfBorg @ryantm