nixos: Shuffle definitions and deprecate system.extraSystemBuilderCmds#460976
Merged
roberth merged 1 commit intoNixOS:staging-nixosfrom Nov 12, 2025
Merged
Conversation
roberth
added
6.topic: nixos
13 tasks
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
roberth
force-pushed
the
deprecate-extraSystemBuilderCmds
branch
from
71adcb1 to
7bb03c1
Compare
arianvp
approved these changes
Nov 12, 2025
arianvp
reviewed
Nov 12, 2025
Member
arianvp
left a comment
arianvp
left a comment
There was a problem hiding this comment.
Oh wait we need to retarget this to staging-nixos I think. As it causes rebuild of all tests
Member
Author
|
Yeah, I thought that was automatic, but only for staging, I guess? |
Shuffle: The definitions are now combined into a single option. Since they have no interdependencies, that's ok, but you may notice this trivial change by a changed hash, and analyzing with nix-diff. Deprecation: Use the option `system.systemBuilderCommands` instead.
nixpkgs-ci
bot
added
12.approvals: 1
roberth
force-pushed
the
deprecate-extraSystemBuilderCmds
branch
from
7bb03c1 to
41b98b4
Compare
Merged
via the queue into
NixOS:staging-nixos
with commit Nov 12, 2025
a5b6d17
35 of 37 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffle:
The definitions are now combined into a single option. Since they have no interdependencies, that's ok, but you may notice this trivial change by a changed hash, and analyzing with nix-diff.
Deprecation:
Use the option
system.systemBuilderCommandsinstead.Context:
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.