top-level: Deprecate top-level {build,host,target}Platform#46059
Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom Sep 6, 2018
Merged
Conversation
GrahamcOfBorg
added
the
8.has: documentation
9 tasks
GrahamcOfBorg
added
10.rebuild-darwin: 0
Ericson2314
force-pushed
the
deprecate-top-level-platform-aliases
branch
from
77ed22c to
3ddf9ed
Compare
I don't know when we can/should remove them, but this at least gets people to stop using them. The preferred alternatives also date back to 17.09 so writing forward-compatable code without extra conditions is easy. Beginning with these as they are the least controversial.
Ericson2314
force-pushed
the
deprecate-top-level-platform-aliases
branch
from
3ddf9ed to
e51f736
Compare
Member
Author
|
Crickets. I'll presume @dezgeg agrees with the spirit of these deprecations (i.e. Unlike the other ones, I created this interface, so I feel comfortable deprecating this myself. @edolstra mentioned cross compilation still being experimental in #45717 (comment). Well, I no longer wish for these top-level to be a "condoned" part of the experiment. (I will not remove them for 18.09, however.) |
This was referenced Sep 6, 2018
Ericson2314
added
the
8.has: port to stable
9 tasks
Member
|
This breaks tarball generation: |
Member
Author
|
Yeah see #46146 (comment) and following. I'm trying to think of what to do. I recall you once tried to the tarball job turn off alises? Maybe I should use that for this instead? |
9 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OK @dezgeg, I'm starting with these since these are the ones we agree on. I'll backport to 18.09 too, if you approve of this.
Motivation for this change
I don't know when we can/should remove them, but this at least gets people to stop using them. The preferred alternatives also date back to 17.09 so writing forward-compatable code without extra conditions is easy.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)