Skip to content

lmms: fix cmake 4 compatibility#459874

Merged
Sigmanificient merged 2 commits intoNixOS:masterfrom
hatch01:lmms
Nov 8, 2025
Merged

lmms: fix cmake 4 compatibility#459874
Sigmanificient merged 2 commits intoNixOS:masterfrom
hatch01:lmms

Conversation

@hatch01
Copy link
Contributor

@hatch01 hatch01 commented Nov 8, 2025

Fix LMMS build failure due to cmake4 : #445447
fixes : #450908
ZHF: #457852
Revert changes made at #73558 since now LMMS also builds successfully on AArch64.

Hydra current build fail logs :
https://hydra.nixos.org/build/302895876

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@hatch01 hatch01 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2025
@hatch01 hatch01 marked this pull request as ready for review November 8, 2025 21:36
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 8, 2025
@hatch01
Copy link
Contributor Author

hatch01 commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 459874
Commit: 3fa29e3faa6b26ab33fa362e5fb393b82d6da5b5 (subsequent changes)
Merge: 81a1cebc0b1e9a3b6d49b8f3cb0f4841994e957a

Logs: https://github.com/hatch01/nixpkgs-review-gha/actions/runs/19199004641


x86_64-linux

✅ 1 package built:
  • lmms

aarch64-linux

No rebuilds


x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@hatch01 hatch01 mentioned this pull request Nov 8, 2025
13 tasks
@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Nov 8, 2025
@hatch01
Copy link
Contributor Author

hatch01 commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 459874
Commit: a53b2873cddf1823cd65a779df7e81af816ca0b6 (subsequent changes)
Merge: bbdca057b9c2ce45464f2f45eb29300668b52cdb

Logs: https://github.com/hatch01/nixpkgs-review-gha/actions/runs/19199333037


x86_64-linux

✅ 1 package built:
  • lmms

aarch64-linux

✅ 1 package built:
  • lmms

@Sigmanificient Sigmanificient added this pull request to the merge queue Nov 8, 2025
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 8, 2025
Merged via the queue into NixOS:master with commit 2081f54 Nov 8, 2025
27 of 31 checks passed
@hatch01
Copy link
Contributor Author

hatch01 commented Nov 8, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 459874
Commit: da03bcff091fbd8d3d018a4dc60548ba2904e793 (subsequent changes)
Merge: 417bc01a67abfa2fd00c286990b37c42e856a90d

Logs: https://github.com/hatch01/nixpkgs-review-gha/actions/runs/19199551283


x86_64-linux

✅ 1 package built:
  • lmms

aarch64-linux

✅ 1 package built:
  • lmms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: lmms - cmake 4.0

2 participants