Skip to content

qt-3: Make configureFlags a list#45888

Merged
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:qt3-configure-flags
Sep 1, 2018
Merged

qt-3: Make configureFlags a list#45888
Ericson2314 merged 1 commit intoNixOS:masterfrom
obsidiansystems:qt3-configure-flags

Conversation

@Ericson2314
Copy link
Member

@Ericson2314 Ericson2314 commented Aug 31, 2018

Motivation for this change

This is cleaner, and makes it easier to limit rebuilds while editing the flags.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 mentioned this pull request Aug 31, 2018
Closed
9 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Aug 31, 2018
@FRidh
Copy link
Member

FRidh commented Sep 1, 2018

Qt 3.3 is from February 2004. I think it's time we drop it from our repository. I see 2 applications using it, lprof, which should be able to use a newer version, and an old version of taskjuggler.

@FRidh
Copy link
Member

FRidh commented Sep 1, 2018

Regarding lprof. Seems Qt4 support was merged in CVS, but there has not been any release with it.

@Ericson2314
Copy link
Member Author

Ericson2314 commented Sep 1, 2018

I think I'll merge this now to help with my proposed configure flags deprecation, but yes I approve of just deleting Qt 3 too.

@Ericson2314 Ericson2314 merged commit 31e6750 into NixOS:master Sep 1, 2018
@Ericson2314 Ericson2314 deleted the qt3-configure-flags branch September 1, 2018 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ericson2314 @FRidh @GrahamcOfBorg