Skip to content

direwolf-unstable: drop cmake-4 (fix build)#458612

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
trofi:direwolf-unstable-fix-build
Nov 5, 2025
Merged

direwolf-unstable: drop cmake-4 (fix build)#458612
pyrox0 merged 1 commit intoNixOS:masterfrom
trofi:direwolf-unstable-fix-build

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Nov 4, 2025

Without the change the build fails as https://hydra.nixos.org/build/310538394:

applying patch /nix/store/m9bm8k97zc0yn514psfnf53x8v1ws49q-c499496bbc237d0efdcacec5786607f5e17c1c7e.patch
patching file CMakeLists.txt
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n]
Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file CMakeLists.txt.rej

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@trofi trofi mentioned this pull request Nov 4, 2025
13 tasks
@trofi
Copy link
Contributor Author

trofi commented Nov 4, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 458612
Commit: 25377c9da185022642b3cc67fd930114426bb0cb


x86_64-linux

✅ 2 packages built:
  • direwolf-unstable
  • nixpkgs-manual

Without the change the build fails as https://hydra.nixos.org/build/310538394:

    applying patch /nix/store/m9bm8k97zc0yn514psfnf53x8v1ws49q-c499496bbc237d0efdcacec5786607f5e17c1c7e.patch
    patching file CMakeLists.txt
    Reversed (or previously applied) patch detected!  Assume -R? [n]
    Apply anyway? [n]
    Skipping patch.
    1 out of 1 hunk ignored -- saving rejects to file CMakeLists.txt.rej
@trofi trofi force-pushed the direwolf-unstable-fix-build branch from 25377c9 to f38f11b Compare November 4, 2025 21:27
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Nov 4, 2025
@Pandapip1 Pandapip1 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Nov 4, 2025
@sarcasticadmin
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 458612
Commit: f38f11b9388ccef700c996f9c531c1930f541aba


x86_64-linux

✅ 1 package built:
  • direwolf-unstable

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 4, 2025
@Pandapip1 Pandapip1 added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 4, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Nov 5, 2025
Merged via the queue into NixOS:master with commit 0462958 Nov 5, 2025
33 of 37 checks passed
@trofi trofi deleted the direwolf-unstable-fix-build branch November 5, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 2 This PR was reviewed and approved by two persons. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants