Skip to content

postgresqlPackages.omnigres: fix build#457872

Closed
schonfinkel wants to merge 1 commit intoNixOS:masterfrom
schonfinkel:FIX-omnigres-build
Closed

postgresqlPackages.omnigres: fix build#457872
schonfinkel wants to merge 1 commit intoNixOS:masterfrom
schonfinkel:FIX-omnigres-build

Conversation

@schonfinkel
Copy link
Member

@schonfinkel schonfinkel commented Nov 2, 2025 •
edited by wolfgangwalther
Loading

There's a current broken build on the omnigres PostgreSQL extension, libfyaml seems to be the cause. I've added another cmake flag and the build is fine now.

Tracking: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@schonfinkel schonfinkel self-assigned this Nov 2, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. labels Nov 2, 2025
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Nov 2, 2025

Please have a look at #445447 for the preferred ways to fix this.

@wolfgangwalther wolfgangwalther mentioned this pull request Nov 2, 2025
Open
@schonfinkel
Copy link
Member Author

schonfinkel commented Nov 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457872
Commit: cf226ec0d5019bd5117ce2b0f83c86dd2cb6d09c

x86_64-linux

✅ 5 packages built:
  • postgresql14Packages.omnigres
  • postgresql15Packages.omnigres
  • postgresql16Packages.omnigres
  • postgresqlPackages.omnigres (postgresql17Packages.omnigres)
  • postgresql18Packages.omnigres

@schonfinkel
Copy link
Member Author

schonfinkel commented Nov 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 457872
Commit: 9d68a0f5dd0a2f96bbbe92e027b327ab815b0bc1

x86_64-linux

✅ 5 packages built:
  • postgresql14Packages.omnigres
  • postgresql15Packages.omnigres
  • postgresql16Packages.omnigres
  • postgresqlPackages.omnigres (postgresql17Packages.omnigres)
  • postgresql18Packages.omnigres

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Nov 2, 2025

That issue mentions the build flag as a last resort and only for a very specific case, which doesn't apply here, I think.

@schonfinkel
Copy link
Member Author

schonfinkel commented Nov 2, 2025 •
edited
Loading

Please have a look at #445447 for the preferred ways to fix this.

I've opted for the last option, given that many dependencies get broken if I go with the substituteInPlace. I'll still try to make it work in a automated way (maybe bulk sed or bulk substituteInPlace will do).

will also check if a upstream fix is possible with @yrashk

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Nov 3, 2025

will also check if a upstream fix is possible with @yrashk

Yes. that would be best. It should be simple to do, I hope.

@Sigmanificient Sigmanificient mentioned this pull request Jan 3, 2026
Merged
13 tasks
@schonfinkel
Copy link
Member Author

schonfinkel commented Jan 4, 2026

Closed in favor of #476671

@schonfinkel schonfinkel closed this Jan 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ma27 Ma27 Awaiting requested review from Ma27

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

@schonfinkel schonfinkel

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@schonfinkel @wolfgangwalther