cplex & oilrush: fix evaluation errors#457769
Open
h0nIg wants to merge 2 commits intoNixOS:masterfrom
Open
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
h0nIg
changed the title
13 tasks
13 tasks
nixpkgs-ci
bot
added
the
9.needs: reviewer
| sourceProvenance = with sourceTypes; [ binaryNativeCode ]; | ||
| license = licenses.unfree; | ||
| platforms = [ "x86_64-linux" ]; | ||
| platforms = if releasePath == null then [ ] else [ "x86_64-linux" ]; |
Contributor
There was a problem hiding this comment.
I think this effective leads to the error message never being visible, so users don't know what they need to do to make this work.
Contributor
Author
There was a problem hiding this comment.
just partially correct, they will be told to
- enable unfree software (same as before)
- enable unsupported platforms (because they did not specify src)
- will see the error message that they need to specify
src(same as before)
it would be the same if we use broken = if .... and NIXPKGS_ALLOW_BROKEN=true, what do you think matches most here @wolfgangwalther ?
Contributor
There was a problem hiding this comment.
The problem is that nobody expects to get to useful information after enabling unsupported platforms.
I think this needs meta.problems: NixOS/rfcs#127
nixpkgs-ci
bot
removed
the
9.needs: reviewer
nixpkgs-ci
bot
added
the
2.status: merge conflict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.