emacsPackages: revert throw#457521
Conversation
We recently retired a lot of old aliases, but emacsPackages is still exposed on search.nixos.org, so should not have been removed. I argued previously, that this should not have been an alias in the first place: If it's exposed on search.nixos.org, then it is expected to be used, too. We will also need that once we teach Eval to evaluate more packages than hydra builds.
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
There was a problem hiding this comment.
If we have to choose one, I slightly prefer removing emacsPackages from search.nixos.org over undeprecating emacsPackages as I said in #437197. But I am also fine with undeprecating emacsPackages. WDYT? cc @adisbladis @AndersonTorres @panchoh
There was a problem hiding this comment.
If emacsPackages gets removed from search.nixos.org, this means that users won’t be able to use search.nixos.org to locate Emacs packages at all, or that they will be exposed differently, maybe with an alternate prefix, or no prefix at all?
(I would think that, as a user, being able to locate Emacs packages at search.nixos.org is desirable, to say the least).
There was a problem hiding this comment.
I prefer removing it too.
The purpose of throw is precisely to break user config and force they to fix it, with the plus of being graceful.
But being graceful to user became being annoying to us packagers. Let's remove it and optionally make some announcement.
There was a problem hiding this comment.
(I would think that, as a user, being able to locate Emacs packages at search.nixos.org is desirable, to say the least).
I very much agree.
Also, remember: Removing it essentially opts out of ever evaluating emacsPackages in CI. It's unlikely that these packages will be built by hydra, OK. Currently this also means they are not tested by GHA Eval. But my goal is to change that in the future. And for that to work, there needs to be something that can be recursed into - emacsPackages.
Again, all other major package sets have this. There is no point in making emacs differ here.
There was a problem hiding this comment.
Adding emacsPackages to CI sounds good! Maybe emacsPackages can be added to CI via something similar packages-ocnfig.nix. (Just saying. I have not read the CI code and I do not think I have a say in CI things.)
4 participants
We recently retired a lot of old aliases, but emacsPackages is still exposed on search.nixos.org, so should not have been removed. I argued previously, that this should not have been an alias in the first place: If it's exposed on search.nixos.org, then it is expected to be used, too.
Now that all aliases are subject to removal, we can't put this in there anymore.
We will also need that once we teach Eval to evaluate more packages than hydra builds.
cc @jopejoe1 @jian-lin
Closes #437197
Things done
Add a 👍 reaction to pull requests you find important.