ci/request-reviews: untangle owner-related bash code#457503
Merged
wolfgangwalther merged 4 commits intoNixOS:masterfrom Nov 2, 2025
Merged
ci/request-reviews: untangle owner-related bash code#457503wolfgangwalther merged 4 commits intoNixOS:masterfrom
wolfgangwalther merged 4 commits intoNixOS:masterfrom
Conversation
nixpkgs-ci
bot
added
10.rebuild-darwin: 0
1 task
Instead of requesting owners and maintainer separately, each with their own limit of 10 review requests, we now run this together. This unties the logic and allows easier refactoring. Also, it gives us a consistent threshold of when not to request reviews anymore, which I set to 15. Before, this could have been anything between 10 and 20, depending on how the reviewers distributed over owners and maintainers.
This is just a refactor, no functional change. It is a preparation for a future change, where `get-code-owners.sh` can be moved entirely into eval/compare. This can only happen once we removed the remaining `gh api` calls from it.
All the github related logic is now bundled in `request-reviewers.sh`. This allows moving the `get-code-owners.sh` file into the eval/compare step in the next commit.
This moves the parsing of ci/OWNERS into the Nix sandbox. We also get rid of checking out the nixpkgs repo another time in the reviewers workflow - we already have everything we need in the eval/compare job. The creation of owners.txt in this way is only temporary, it should eventually be moved further, similar to how maintainers.json is currently migrating to a maintainer map for the whole repo stored on the target branch as artifact.
wolfgangwalther
force-pushed
the
ci-owners-refactor
branch
from
8bd71c8 to
3bef0dc
Compare
nix-owners
bot
requested review from
MattSturgeon,
Mic92,
philiptaron and
zowoq
MattSturgeon
approved these changes
Nov 2, 2025
Contributor
MattSturgeon
left a comment
MattSturgeon
left a comment
There was a problem hiding this comment.
Can't spot any obvious issues.
nixpkgs-ci
bot
added
the
12.approvals: 1
Contributor
Author
|
(I think this will make the reviewers job fail when it is triggered when a PR is undrafted, but no other Eval run happens - I think these cases will not happen to often, though, and I can watch out for them in the Actions tab easily) |
Contributor
|
Successfully created backport PR for |
1 task
github-actions
bot
added
the
8.has: port to stable
Contributor
Author
|
I see jobs failing like this currently: Should be fixed in #457838. |
1 task
Contributor
Author
|
And one more for PRs without relevant code owners: Fix in #457843 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Four refactors to untangle the various scripts in
ci/request-reviews. This should help with #456481 (comment).Things done
Add a 👍 reaction to pull requests you find important.