Skip to content

lib: deprecate fold#456532

Merged
hsjobeki merged 2 commits intoNixOS:masterfrom
qweered:foldr
Nov 25, 2025
Merged

lib: deprecate fold#456532
hsjobeki merged 2 commits intoNixOS:masterfrom
qweered:foldr

Conversation

@qweered
Copy link
Copy Markdown
Contributor

@qweered qweered commented Oct 28, 2025 •
edited
Loading

Solved fixme

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: lib The Nixpkgs function library labels Oct 28, 2025
@nix-owners nix-owners Bot requested review from hsjobeki and infinisil October 28, 2025 18:58
@qweered qweered force-pushed the foldr branch 2 times, most recently from 2f46e42 to b48f6b8 Compare October 28, 2025 19:11
hsjobeki
hsjobeki reviewed Oct 29, 2025
View reviewed changes
Comment thread lib/lists.nix Outdated
hsjobeki
hsjobeki requested changes Oct 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@hsjobeki hsjobeki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems lgtm; only please be a bit more fancy with docs, they get rendered into the manual.

Not saying the initial state here was any better :) because it doesn't explain what the function does.

@qweered qweered requested a review from hsjobeki October 30, 2025 14:54
@qweered
Copy link
Copy Markdown
Contributor Author

qweered commented Oct 30, 2025

Done

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 25, 2025
@hsjobeki hsjobeki added this pull request to the merge queue Nov 25, 2025
Merged via the queue into NixOS:master with commit 3ae8192 Nov 25, 2025
31 of 33 checks passed
@qweered qweered deleted the foldr branch December 3, 2025 23:02
PerchunPak added a commit to PerchunPak/snowfall-lib that referenced this pull request Dec 4, 2025
@PerchunPak
Use lib.foldr instead of lib.fold
2f4626b 
`lib.fold` alias is deprecated, see
NixOS/nixpkgs#456532
@PerchunPak PerchunPak mentioned this pull request Dec 4, 2025
Closed
This was referenced Feb 1, 2026
Closed
Closed
NorfairKing pushed a commit to NorfairKing/smos that referenced this pull request Feb 2, 2026
@arut-plus
nix: using lib.foldr due to deprecated lib.fold
52c5b82 
NixOS/nixpkgs#456532
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@hsjobeki hsjobeki hsjobeki approved these changes

@infinisil infinisil Awaiting requested review from infinisil

@philiptaron philiptaron Awaiting requested review from philiptaron

Assignees

No one assigned

Labels

6.topic: lib The Nixpkgs function library 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qweered @SuperSandro2000 @hsjobeki