mmseqs2: avoid pkgsStatic#456530
Merged
wolfgangwalther merged 1 commit intoNixOS:masterfrom Oct 28, 2025
Merged
Conversation
Pulling in a zstd built with possibly a different libc, from an entirely different package set and putting it in nativeBuildInputs is.. brave!
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
emilazy
reviewed
Oct 28, 2025
Comment on lines
+65
to
+66
| zlib | ||
| bzip2 |
Member
There was a problem hiding this comment.
(FWIW, I doubt these are only required on Clang – more likely it falls back to vendored versions and it just so happens that Clang is exposing build failures in older vendored versions of these?
Not a blocker, of course, since it’s pre‐existing.)
Contributor
Author
There was a problem hiding this comment.
I tested: zlib and bzip2 are optional both with and without clang. The source repo doesn't look like these are vendored either, the configure output just says that these are not found and all is good.
Won't do anything here, though.
Contributor
Author
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulling in a zstd built with possibly a different libc, from an entirely different package set and putting it in nativeBuildInputs is.. brave!
Things done
nixpkgs-reviewon this PR. See nixpkgs-review usage.Add a 👍 reaction to pull requests you find important.