aliases: adjust warnings#456527
Conversation
These are more potentially load‐bearing than the rest.
5659821 to
b6d112f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
That was solved by #456512, no? |
Yes, thanks. |
|
Fixing |
Nixpkgs maintainers are fucking around again. Two occurences on the same day, even. What a surprise. (NixOS/nixpkgs#456527) In true nixpkgs fashion, we don't even get a decent error message for that. ``` error: attempt to call something which is not a function but a string: "linuxArch" at /nix/store/637jq68bl0pwqkiv2ms2p58x3mfpnhz6-source/common/common.nix:13:178: 12| # TODO: check if this unhardcoding of the arch in hostPlatform.config actually works 13| pkgsGnu = import inputs.nixpkgs { config.allowUnfree = config.nixpkgs.config.allowUnfree; localSystem.system = final.stdenv.hostPlatform.system; localSystem.config = "${pkgs.hostPlatform.linuxArch}-unknown-linux-gnu"; config.cudaSupport = true; config.cudaVersion = "12";}; | ^ ``` Still getting a 'evaluation warning: 'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'' now but idk where tf I'm using 'system' on my config...
'system' has been renamed to/replaced by 'stdenv.hostPlatform.system' NixOS/nixpkgs#456527
'system' has been renamed to/replaced by 'stdenv.hostPlatform.system' NixOS/nixpkgs#456527
|
That decision was made a long time ago, we just followed through on it. |
|
Fair. I can make a new issue - I just think that in a flakey world, |
"Lots of uses" != sensible. Cargo culting is a thing. FWIW I've always advised using the full form, knowing that |
Caused by NixOS/nixpkgs#456527 Fixes #137 and #119
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Access of top-level `*system` alieases is being deprecated and the attributes are going to be removed in a future release of nixpkgs. This replaces them with the more precise `stdenv.*` attributes. See: <NixOS/nixpkgs#456527>
Access of top-level `*system` alieases is being deprecated and the attributes are going to be removed in a future release of nixpkgs. This replaces them with the more precise `stdenv.*` attributes. See: <NixOS/nixpkgs#456527>
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
* feat: enable nixosTest on aarch64 darwin Build nixosTest using a local aarch64 linux builder and run nixosTest qemu VM in aarch64 darwin. This keeps the tests fast as they don't require nested virtualisation. For example, you can run the nixos test for the http extension on your aarch64 macOS with: ```shell nix build .\#checks.aarch64-darwin.ext-http ``` * chore: reduce warnings related to system Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527 * fix: remove redundant postgresqlWithExtension wrapper in extension tests The tests were unnecessarily wrapping psql_15 with postgresqlWithExtension when psql_15 already includes the extensions. * fix: remove port forwarding from test configurations This cause problem starting nixos tests on darwin hosts. * fix: remaining nixos test references to use pkgs.pkgsLinux - self.legacyPackages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system - self.packages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system * fix: improve HTTP mock server error handling and directory creation - Guard against empty dirname when creating port file directory - Use bare 'raise' to preserve original exception traceback - Only create directory if dirname is non-empty * fix: check full PostGIS version instead of just major version Changes the version assertion to compare the complete version string rather than only the major version, providing more precise validation. --------- Co-authored-by: Yvan Sraka <[email protected]>
In change nkzyltot (2d2056e, flake: fix eval warning), pkgs.system was changed to pkgs.stdenv.hostPlatform.system. This was required after NixOS/nixpkgs#456527 made using pkgs.system a warning Unfortunately you missed one... oops Signed-off-by: Skyler Grey <[email protected]>
* feat: enable nixosTest on aarch64 darwin Build nixosTest using a local aarch64 linux builder and run nixosTest qemu VM in aarch64 darwin. This keeps the tests fast as they don't require nested virtualisation. For example, you can run the nixos test for the http extension on your aarch64 macOS with: ```shell nix build .\#checks.aarch64-darwin.ext-http ``` * chore: reduce warnings related to system Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527 * fix: remove redundant postgresqlWithExtension wrapper in extension tests The tests were unnecessarily wrapping psql_15 with postgresqlWithExtension when psql_15 already includes the extensions. * fix: remove port forwarding from test configurations This cause problem starting nixos tests on darwin hosts. * fix: remaining nixos test references to use pkgs.pkgsLinux - self.legacyPackages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system - self.packages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system * fix: improve HTTP mock server error handling and directory creation - Guard against empty dirname when creating port file directory - Use bare 'raise' to preserve original exception traceback - Only create directory if dirname is non-empty * fix: check full PostGIS version instead of just major version Changes the version assertion to compare the complete version string rather than only the major version, providing more precise validation. --------- Co-authored-by: Yvan Sraka <[email protected]>
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.