Skip to content

aliases: adjust warnings#456527

Merged
wolfgangwalther merged 5 commits intoNixOS:masterfrom
emilazy:push-xtqzoupnztmt
Oct 30, 2025
Merged

aliases: adjust warnings#456527
wolfgangwalther merged 5 commits intoNixOS:masterfrom
emilazy:push-xtqzoupnztmt

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Oct 28, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 28, 2025
Copy link
Contributor

@qweered qweered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 28, 2025
@zowoq

This comment was marked as resolved.

@emilazy
Copy link
Member Author

emilazy commented Oct 29, 2025

That was solved by #456512, no?

@zowoq
Copy link
Contributor

zowoq commented Oct 29, 2025

That was solved by #456512, no?

Yes, thanks.

Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Oct 30, 2025
Merged via the queue into NixOS:master with commit dcf56ed Oct 30, 2025
29 of 31 checks passed
@wolfgangwalther
Copy link
Contributor

Fixing system to use a regular warning in #457057.

@emilazy emilazy mentioned this pull request Oct 31, 2025
13 tasks
@keysmashes keysmashes mentioned this pull request Oct 31, 2025
13 tasks
LuNeder added a commit to LuNeder/nixos-config that referenced this pull request Nov 1, 2025
Nixpkgs maintainers are fucking around again. Two occurences on the same day, even. What a surprise.
(NixOS/nixpkgs#456527)

In true nixpkgs fashion, we don't even get a decent error message for that.

```
       error: attempt to call something which is not a function but a string: "linuxArch"
       at /nix/store/637jq68bl0pwqkiv2ms2p58x3mfpnhz6-source/common/common.nix:13:178:
           12|       # TODO: check if this unhardcoding of the arch in hostPlatform.config actually works
           13|       pkgsGnu = import inputs.nixpkgs {  config.allowUnfree = config.nixpkgs.config.allowUnfree;  localSystem.system = final.stdenv.hostPlatform.system; localSystem.config = "${pkgs.hostPlatform.linuxArch}-unknown-linux-gnu"; config.cudaSupport = true; config.cudaVersion = "12";};
             |                                                                                                                                                                                  ^
```

Still getting a 'evaluation warning: 'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'' now but idk where tf I'm using 'system' on my config...
gigamonster256 added a commit to gigamonster256/ghostty that referenced this pull request Nov 2, 2025
'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'
NixOS/nixpkgs#456527
mitchellh added a commit to ghostty-org/ghostty that referenced this pull request Nov 2, 2025
'system' has been renamed to/replaced by 'stdenv.hostPlatform.system'

NixOS/nixpkgs#456527
@wolfgangwalther
Copy link
Contributor

That decision was made a long time ago, we just followed through on it.

@llakala
Copy link
Contributor

llakala commented Nov 3, 2025

Fair. I can make a new issue - I just think that in a flakey world, pkgs.system is specifically meaningful (15.4k uses!), and we should be wary of turning this into a throw unless we're absolutely sure it's the right decision.

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Nov 4, 2025

pkgs.system is specifically meaningful (15.4k uses!),

"Lots of uses" != sensible. Cargo culting is a thing.
There are up to three systems involved in a compilation stage, knowing which one you're using is actually important (flakes' questionable design notwithstanding). Though targetPlatform is often not so relevant.

FWIW I've always advised using the full form, knowing that pkgs.system is deprecated.

samestep added a commit to samestep/npc that referenced this pull request Nov 4, 2025
phip1611 added a commit to phip1611/nixos-configs that referenced this pull request Nov 10, 2025
phip1611 added a commit to phip1611/nixos-configs that referenced this pull request Nov 10, 2025
SuperSamus added a commit to SuperSamus/nix-gaming that referenced this pull request Nov 16, 2025
SuperSamus added a commit to SuperSamus/nix-gaming that referenced this pull request Nov 16, 2025
zimbatm added a commit to numtide/blueprint that referenced this pull request Nov 16, 2025
zimbatm added a commit to numtide/blueprint that referenced this pull request Nov 16, 2025
fufexan pushed a commit to fufexan/nix-gaming that referenced this pull request Nov 16, 2025
phip1611 added a commit to phip1611/nixos-configs that referenced this pull request Nov 24, 2025
phip1611 added a commit to phip1611/nixos-configs that referenced this pull request Nov 26, 2025
phip1611 added a commit to phip1611/nixos-configs that referenced this pull request Nov 26, 2025
jfroche added a commit to supabase/postgres that referenced this pull request Dec 22, 2025
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
jfroche added a commit to supabase/postgres that referenced this pull request Dec 22, 2025
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
jfroche added a commit to supabase/postgres that referenced this pull request Dec 22, 2025
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
ysndr added a commit to flox/flox that referenced this pull request Dec 28, 2025
Access of top-level `*system` alieases is being deprecated
and the attributes are going to be removed in a future release
of nixpkgs.
This replaces them with the more precise `stdenv.*` attributes.

See: <NixOS/nixpkgs#456527>
ysndr added a commit to flox/flox that referenced this pull request Dec 30, 2025
Access of top-level `*system` alieases is being deprecated
and the attributes are going to be removed in a future release
of nixpkgs.
This replaces them with the more precise `stdenv.*` attributes.

See: <NixOS/nixpkgs#456527>
jfroche added a commit to supabase/postgres that referenced this pull request Jan 16, 2026
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Jan 28, 2026
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Jan 28, 2026
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
yvan-sraka pushed a commit to supabase/postgres that referenced this pull request Feb 3, 2026
Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527
github-merge-queue bot pushed a commit to supabase/postgres that referenced this pull request Feb 4, 2026
* feat: enable nixosTest on aarch64 darwin

Build nixosTest using a local aarch64 linux builder and run nixosTest qemu VM in
aarch64 darwin. This keeps the tests fast as they don't require nested virtualisation.

For example, you can run the nixos test for the http extension on your aarch64 macOS with:

```shell
nix build .\#checks.aarch64-darwin.ext-http
```

* chore: reduce warnings related to system

Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527

* fix: remove redundant postgresqlWithExtension wrapper in extension tests

The tests were unnecessarily wrapping psql_15 with postgresqlWithExtension when psql_15 already includes the extensions.

* fix: remove port forwarding from test configurations

This cause problem starting nixos tests on darwin hosts.

* fix: remaining nixos test references to use pkgs.pkgsLinux

- self.legacyPackages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system
- self.packages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system

* fix: improve HTTP mock server error handling and directory creation

- Guard against empty dirname when creating port file directory
- Use bare 'raise' to preserve original exception traceback
- Only create directory if dirname is non-empty

* fix: check full PostGIS version instead of just major version

Changes the version assertion to compare the complete version string
rather than only the major version, providing more precise validation.

---------

Co-authored-by: Yvan Sraka <[email protected]>
DzmingLi pushed a commit to DzmingLi/tangled-pijul-support-fork that referenced this pull request Feb 12, 2026
In change nkzyltot (2d2056e, flake: fix eval warning), pkgs.system
was changed to pkgs.stdenv.hostPlatform.system. This was required after
NixOS/nixpkgs#456527 made using pkgs.system
a warning

Unfortunately you missed one... oops

Signed-off-by: Skyler Grey <[email protected]>
encima pushed a commit to supabase/postgres that referenced this pull request Feb 23, 2026
* feat: enable nixosTest on aarch64 darwin

Build nixosTest using a local aarch64 linux builder and run nixosTest qemu VM in
aarch64 darwin. This keeps the tests fast as they don't require nested virtualisation.

For example, you can run the nixos test for the http extension on your aarch64 macOS with:

```shell
nix build .\#checks.aarch64-darwin.ext-http
```

* chore: reduce warnings related to system

Current system value has been moved into `pkgs.stdenv.hostPlatform` by NixOS/nixpkgs#456527

* fix: remove redundant postgresqlWithExtension wrapper in extension tests

The tests were unnecessarily wrapping psql_15 with postgresqlWithExtension when psql_15 already includes the extensions.

* fix: remove port forwarding from test configurations

This cause problem starting nixos tests on darwin hosts.

* fix: remaining nixos test references to use pkgs.pkgsLinux

- self.legacyPackages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system
- self.packages.${pkgs.stdenv.hostPlatform.system} -> pkgs.pkgsLinux.stdenv.hostPlatform.system

* fix: improve HTTP mock server error handling and directory creation

- Guard against empty dirname when creating port file directory
- Use bare 'raise' to preserve original exception traceback
- Only create directory if dirname is non-empty

* fix: check full PostGIS version instead of just major version

Changes the version assertion to compare the complete version string
rather than only the major version, providing more precise validation.

---------

Co-authored-by: Yvan Sraka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants