buildMozillaMach: use llvmPackages_20 on aarch64-darwin#456351
Merged
mweinelt merged 1 commit intoNixOS:masterfrom Oct 28, 2025
Merged
buildMozillaMach: use llvmPackages_20 on aarch64-darwin#456351mweinelt merged 1 commit intoNixOS:masterfrom
mweinelt merged 1 commit intoNixOS:masterfrom
Conversation
nixpkgs-ci
Bot
added
10.rebuild-darwin: 11-100
Contributor
|
@booxter I also thought it would be important to link this issue as well https://bugzilla.mozilla.org/show_bug.cgi?id=1995582 |
Contributor
Author
|
It's not just "important". This was the link I was supposed to paste, it's a typo. :) I am also going to move this special case for LLVM 20 into the builder helper function because looks like there are still some scenarios when at least some build inputs will be 21 despite the override (specifically for LTO). |
There's a bug in llvm 21 that makes Firefox crash on loading a PNG favicon that is being investigated in Mozilla bug tracker: https://bugzilla.mozilla.org/show_bug.cgi?id=1995582 While this is being fixed, switch to llvmPackages_20 for aarch64-darwin. (x86_64-darwin is not affected.) Note: this change will also affect Thunderbird. Though strictly speaking not a required change because we are not aware of a specific issue with Thunderbird (yet), I feel we may want to stick to the same LLVM for both types of Mozilla apps while this is being investigated. It also simplifies the code somewhat. Fixes NixOS#453372
nixpkgs-ci
Bot
removed
the
9.needs: reviewer
booxter
force-pushed
the
ff-llvm-21-issue
branch
from
43bb675 to
40eea21
Compare
nix-owners
Bot
requested review from
DominicWrege,
LordGrimmauld,
fpletz,
jopejoe1,
lovesegfault,
mweinelt,
nbp,
rhendric,
squalus and
vcunat
Contributor
Author
|
mweinelt
approved these changes
Oct 28, 2025
nixpkgs-ci
Bot
added
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bug in llvm 21 that makes Firefox crash on loading a PNG
favicon that is being investigated in Mozilla bug tracker:
https://bugzilla.mozilla.org/show_bug.cgi?id=1995582
While this is being fixed, switch to llvmPackages_20 for aarch64-darwin.
(x86_64-darwin is not affected.)
Note: this change will also affect Thunderbird. Though strictly speaking
not a required change because we are not aware of a specific issue with
Thunderbird (yet), I feel we may want to stick to the same LLVM for both
types of Mozilla apps while this is being investigated. It also
simplifies the code somewhat.
Fixes #453372
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.