Skip to content

protobuf_27: fix build by pinning abseil to 202407#456013

Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom
iedame:cmake4/protobuf_27
Oct 27, 2025
Merged

protobuf_27: fix build by pinning abseil to 202407#456013
GaetanLepage merged 1 commit intoNixOS:masterfrom
iedame:cmake4/protobuf_27

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 26, 2025 •
edited
Loading

originally in #445447, but seems unrelated to cmake4.

latest abseil-cpp does not provide if_constexpr in its cmake files.
Pinning abseil to 202407 fixes the build.

Same fix used by protobuf_29 in #422705

closes #455929

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 26, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 26, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 456013
Commit: 4e00e02cb8306d5171d860ba8db5385d862926b6 (subsequent changes)
Merge: 24ace97f7d91849f9feff75b9e7450041b36ef74

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18824469259

x86_64-linux

✅ 5 packages built:
  • protobuf_27
  • python312Packages.gpapi
  • python312Packages.gpapi.dist
  • python313Packages.gpapi
  • python313Packages.gpapi.dist

aarch64-linux

✅ 5 packages built:
  • protobuf_27
  • python312Packages.gpapi
  • python312Packages.gpapi.dist
  • python313Packages.gpapi
  • python313Packages.gpapi.dist

x86_64-darwin (sandbox = true)

✅ 5 packages built:
  • protobuf_27
  • python312Packages.gpapi
  • python312Packages.gpapi.dist
  • python313Packages.gpapi
  • python313Packages.gpapi.dist

aarch64-darwin (sandbox = true)

✅ 5 packages built:
  • protobuf_27
  • python312Packages.gpapi
  • python312Packages.gpapi.dist
  • python313Packages.gpapi
  • python313Packages.gpapi.dist

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 27, 2025
GaetanLepage
GaetanLepage approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@GaetanLepage GaetanLepage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@GaetanLepage GaetanLepage added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit aff6c86 Oct 27, 2025
32 of 35 checks passed
@iedame iedame deleted the cmake4/protobuf_27 branch October 27, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build failure: protobuf_27

2 participants

@iedame @GaetanLepage