• Tracking: Build Failures with CMake 4 #445447

I noticed there is one PR for this package already #450025, but it doesn't include cleanup or the python derivation.

I noticed there is one PR for this package already #450025, but it doesn't include cleanup or the python derivation.

Maybe we can merge this one then.
I was not able to fix the python module which fails building hyperscan.override { withStatic = true; } with:

CMake Error at pcre/CMakeLists.txt:843 (GET_TARGET_PROPERTY):
  The LOCATION property may not be read from target "pcretest".  Use the
  target name directly with add_custom_command, or use the generator
  expression $<TARGET_FILE>, as appropriate.

This PR still fixes the regular hyperscan build.

@GaetanLepage doesnt build for me

     > -- Performing Test CXX_UNUSED_LOCAL_TYPEDEFS
       > -- Performing Test CXX_UNUSED_LOCAL_TYPEDEFS - Success
       > -- Performing Test CXX_WUNUSED_VARIABLE
       > -- Performing Test CXX_WUNUSED_VARIABLE - Success
       > -- Performing Test CC_STRINGOP_OVERFLOW
       > -- Performing Test CC_STRINGOP_OVERFLOW - Success
       > -- Performing Test CXX_STRINGOP_OVERFLOW
       > -- Performing Test CXX_STRINGOP_OVERFLOW - Success
       > -- Building runtime for multiple microarchitectures
       > -- Looking for mmap
       > -- Looking for mmap - found
       > -- Doxygen not found, unable to generate API reference
       > -- Sphinx not found, unable to generate developer reference
       > -- PCRE version 8.41 or above - building from source.
       > CMake Error at pcre/CMakeLists.txt:79 (CMAKE_MINIMUM_REQUIRED):
       >   Compatibility with CMake < 3.5 has been removed from CMake.
       >
       >   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
       >   to tell CMake that the project requires at least <min> but has been updated
       >   to work with policies introduced by <max> or earlier.
       >
       >   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
       >
       >
       > -- Configuring incomplete, errors occurred!
       For full logs, run:
         nix log /nix/store/vv165bvx7gip3bypxdss91x9s16ixf10-hyperscan-5.4.2.drv

Looks like pcre/CMakeLists.txt also needs its cmake_minimum_required patched.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455992
Commit: 4bc2adba45dd83c9d5f8fdfea82323b3951fea1f

x86_64-linux

x86_64-darwin

@GaetanLepage doesnt build for me

     > -- Performing Test CXX_UNUSED_LOCAL_TYPEDEFS
       > -- Performing Test CXX_UNUSED_LOCAL_TYPEDEFS - Success
       > -- Performing Test CXX_WUNUSED_VARIABLE
       > -- Performing Test CXX_WUNUSED_VARIABLE - Success
       > -- Performing Test CC_STRINGOP_OVERFLOW
       > -- Performing Test CC_STRINGOP_OVERFLOW - Success
       > -- Performing Test CXX_STRINGOP_OVERFLOW
       > -- Performing Test CXX_STRINGOP_OVERFLOW - Success
       > -- Building runtime for multiple microarchitectures
       > -- Looking for mmap
       > -- Looking for mmap - found
       > -- Doxygen not found, unable to generate API reference
       > -- Sphinx not found, unable to generate developer reference
       > -- PCRE version 8.41 or above - building from source.
       > CMake Error at pcre/CMakeLists.txt:79 (CMAKE_MINIMUM_REQUIRED):
       >   Compatibility with CMake < 3.5 has been removed from CMake.
       >
       >   Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
       >   to tell CMake that the project requires at least <min> but has been updated
       >   to work with policies introduced by <max> or earlier.
       >
       >   Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.
       >
       >
       > -- Configuring incomplete, errors occurred!
       For full logs, run:
         nix log /nix/store/vv165bvx7gip3bypxdss91x9s16ixf10-hyperscan-5.4.2.drv

Yes, it fails with withStatic = true, but I think this PR is still worth to merge.
#455992 (comment)

# CMake Error at pcre/CMakeLists.txt:843 (GET_TARGET_PROPERTY):
#  The LOCATION property may not be read from target "pcretest".  Use the
#  target name directly with add_custom_command, or use the generator
#  expression $<TARGET_FILE>, as appropriate.

@GaetanLepage I'm pretty sure that's related to https://cmake.org/cmake/help/v3.0/policy/CMP0026.html

I was able to build withStatic = true using this:

  preConfigure = lib.optionalString withStatic (
    ''
      mkdir -p pcre
      tar xvf ${pcre.src} --strip-components 1 -C pcre
    ''
    # CMake 4 dropped support of versions lower than 3.5,
    # versions lower than 3.10 are deprecated.
    # https://github.com/NixOS/nixpkgs/issues/445447
    + ''
      substituteInPlace pcre/CMakeLists.txt \
        --replace-fail "CMAKE_MINIMUM_REQUIRED(VERSION 2.8.5)" "CMAKE_MINIMUM_REQUIRED(VERSION 3.10)" \
        --replace-fail "CMAKE_POLICY(SET CMP0026 OLD)" "CMAKE_POLICY(SET CMP0026 NEW)" \
        --replace-fail "GET_TARGET_PROPERTY(PCRETEST_EXE pcretest DEBUG_LOCATION)" "set(PCRETEST_EXE $<TARGET_FILE:pcretest>)"
    ''
  );

I had a similar issue with another package a few days ago so the error was familiar to me.

Applying that I am able to build hyperscan and python3Packages.hyperscan without any errors.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455992
Commit: 5e6d48156f1de18709d1903b33d9f4c74b9ddc66

x86_64-linux

x86_64-darwin

Ok, everything is building now!