Skip to content

malt: fix build with cmake4#455989

Closed
iedame wants to merge 1 commit intoNixOS:masterfrom
iedame:cmake4/malt--
Closed

malt: fix build with cmake4#455989
iedame wants to merge 1 commit intoNixOS:masterfrom
iedame:cmake4/malt--

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 26, 2025

Edit: Closed in favor of #456259

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 26, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455989
Commit: dc4935dcd962b5a993ef4eec7207d6026d0532d8 (subsequent changes)
Merge: 4549d3486240a4cb3f9bc0b60af84d8854407b37

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18823930382


x86_64-linux

✅ 1 package built:
  • malt

aarch64-linux

✅ 1 package built:
  • malt

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@SkohTV
Copy link
Member

SkohTV commented Oct 27, 2025

There already is an upstream commit fixing this memtt/malt@ffbc9f3
Just updating the package from 1.2.6 to 1.4.1 should be enough

@iedame
Copy link
Contributor Author

iedame commented Oct 27, 2025

There already is an upstream commit fixing this memtt/malt@ffbc9f3 Just updating the package from 1.2.6 to 1.4.1 should be enough

The current version in nixpkgs cannot apply that patch because it is older.

My motivation is to get this building again (see https://hydra.nixos.org/build/310415786), I fixed 130+ packages so I did not have time to bump a few packages that might have non-trivial updates, or that might break functionality if hastily implemented, and I am not the maintainer of that package after all.

You are more than welcome to open a PR to update it to 1.4.1 and we can merge that instead.

@SkohTV SkohTV mentioned this pull request Oct 27, 2025
13 tasks
@SkohTV
Copy link
Member

SkohTV commented Oct 27, 2025

The package is not maintained by anyone, so unlikely to get an update any time soon

@iedame
Copy link
Contributor Author

iedame commented Oct 27, 2025

Thank you for the update PR! Closing this one in favor of #456259

@iedame iedame closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

9.needs: reviewer This PR currently has no reviewers requested and needs attention. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants