maintainers: drop figsoda #455942
Merged
wolfgangwalther merged 5 commits intoNixOS:masterfrom Nov 3, 2025
Merged
Conversation
mdaniels5757
force-pushed
the
drop-figsoda-as-maintainer
branch
from
8902af1 to
118a3b8
Compare
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
Member
|
Commiter rights need to be handled by @NixOS/commit-bit-delegation also CC @infinisil as well about auto removing commiter rights. |
mdaniels5757
force-pushed
the
drop-figsoda-as-maintainer
branch
from
118a3b8 to
c67dd16
Compare
Member
Author
|
Their last merge was Nov 25, 2024, so I assume the bot will make a PR to remove them in a month or so. |
Contributor
|
what a legendary fella 😢 thank him for his service 🫡 |
mdaniels5757
force-pushed
the
drop-figsoda-as-maintainer
branch
2 times, most recently
from
0b31387 to
c7ff6c8
Compare
nixpkgs-ci
bot
added
the
2.status: merge conflict
mdaniels5757
force-pushed
the
drop-figsoda-as-maintainer
branch
from
c7ff6c8 to
39005a4
Compare
7 tasks
nixpkgs-ci
bot
removed
the
2.status: merge conflict
JohnRTitor
reviewed
Oct 29, 2025
Member
|
Also please look into creating issues of looking for maintainer of packages that have no maintainer if @figsoda doesn't respond. |
s/maintainers = with lib.maintainers; [ figsoda ];/maintainers = with lib.maintainers; [ ];/
s/maintainers = with maintainers; [ figsoda ];/maintainers = with maintainers; [ ];/
s/^\s*figsoda\s*$//
These were done manually by me, either due to not matching the regexes in the previous ones, or because of nixf-diagnose, which I have as a pre-commit hook.
Inactive.
mdaniels5757
force-pushed
the
drop-figsoda-as-maintainer
branch
from
39005a4 to
ea5e3b2
Compare
Member
Author
|
A week has passed. @Mic92 @zowoq @winterqt could one of you please:
Thanks! |
Contributor
Done: #457964 |
wolfgangwalther
approved these changes
Nov 3, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
We have two rebuilds:
- nixos-install-tools
- tests.nixos-functions.nixos-test
Both of these are irrelevant - they just include parts of the nixpkgs source somewhere, so change whenever.
Diff LGTM.
@figsoda thank you! You are welcome back anytime!
nixpkgs-ci
bot
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
figsoda does not seem to have had any nixpkgs activity since 2024. Their last review was in Feburary 2024, per #455328 (review).
Because figsoda maintained so many packages, I split up my commits by the regex I used.
@figsoda: if you'd like to stay involved as maintainer, please respond within a week.
Finally, I see that figsoda is a committer as well. That is not changed by this PR.
Things done
Add a 👍 reaction to pull requests you find important.