lzham: 1.0 -> 1.0-unstable-2023-05-14#455885
Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom Nov 4, 2025
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
LordGrimmauld
requested changes
Nov 4, 2025
ff9599e to
9278a4d
Compare
Contributor
Author
|
@LordGrimmauld All suggested changes applied, thank you for the review! I'm still relatively new to nixpkgs so I appreciate the explanations. |
This comment was marked as outdated.
This comment was marked as outdated.
9278a4d to
3cce15b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
lzhamto latest unstable devel, according to upstream is improved and 100% backwards compatible with lzham v1.0.I changed the installPhase so it installs the
libandincludeand then move lzhamtestbinto correct place.result folder look like this:
Result from
lzhamtest:Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.