Skip to content

opentx: fix build with cmake4#455753

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opentx-
Nov 1, 2025
Merged

opentx: fix build with cmake4#455753
LordGrimmauld merged 1 commit intoNixOS:masterfrom
iedame:cmake4/opentx-

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 26, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 26, 2025
@nix-owners nix-owners bot requested review from elitak and lopsided98 October 26, 2025 08:44
@iedame
Copy link
Contributor Author

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455753
Commit: 872f3028e4d9e20118c45812cb6cc86d29619b03 (subsequent changes)
Merge: e11856806704b73565366ecc28ada4369053900f

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18815572231


x86_64-linux

✅ 1 package built:
  • opentx

aarch64-linux

✅ 1 package built:
  • opentx

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came accross this failure in #457112 (comment).
Diff lgtm, opentx builds and runs on x86_64-linux. No upstream patches for cmake 4 compat, so --replace-fail is reasonable. Thank you :)

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Nov 1, 2025
Merged via the queue into NixOS:master with commit f73367e Nov 1, 2025
31 of 33 checks passed
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Nov 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants