aliases: cleanups and keep-sorted#455735
Conversation
dbdccbc to
8b0c7bf
Compare
8b0c7bf to
f54e847
Compare
wolfgangwalther
left a comment
There was a problem hiding this comment.
Left a few comments, the pattern should be clear: Let's move all manual modifications into commits before the keep-sorted one, so that we can easily recreate the latter.
9cd32ad to
5200c5e
Compare
|
Done |
32e3736 to
5e201ed
Compare
emilazy
left a comment
There was a problem hiding this comment.
Overall neutral on this. Some of the organization this disrupts is intentional / something I’ve found useful, but OTOH there are a lot of arbitrary weirdnesses in the file too. The aliases.nix file is somewhat unmaintainable with the current system in general, so I guess I’m really fine with any ordering :)
The general clean‐ups are definitely good, and may help with a final round of dropping with #427017.
cc @wolfgangwalther – do we want to land this? I think I’ve talked myself into it being a good idea while writing this.
bdd3218 to
1d57214
Compare
|
Note: throw '' '' (aka multiline) need to be replaced with default throw " " for keep sorted to work |
wolfgangwalther
left a comment
There was a problem hiding this comment.
Good stuff, thank you!
I went through the commits, adjusted the commit messages a bit and move some more "preserve" aliases to the top in the second commit. I also dropped the commit that changed '' to " for multi-line messages, because I believe this changes the messages contents.
With the split, I was able to recreate the last commit easily, nice.
(I also adjusted the commit hash in .git-blame-ignore-revs after my rebase)
Oh, I didn't notice that, let me see whether I broke that with the latest drop of that commit. |
1d57214 to
11c7b83
Compare
Indeed, I see what you mean. It's odd that treefmt ran mostly fine the first time - and only when I ran it again, it started to break everything. I put that commit back in. |
Does |
|
Oops it already has it :) |
These header comments won't be useful anymore with keep-sorted sorting, while the comment about nixops is just outdated.
11c7b83 to
3dbd480
Compare
The problem is that |
|
🎉 Same for darwin-aliases #455798 |
|
it looks to me that this PR broke pkgs/top-level/aliases.nix file. I get |
|
Working on a fix |
Uh oh!
There was an error while loading. Please reload this page.