Skip to content

orthanc-plugin-dicomweb: fix build with cmake4#455671

Merged
drupol merged 1 commit intoNixOS:masterfrom
iedame:cmake4/orthanc-plugin-dicomweb
Oct 26, 2025
Merged

orthanc-plugin-dicomweb: fix build with cmake4#455671
drupol merged 1 commit intoNixOS:masterfrom
iedame:cmake4/orthanc-plugin-dicomweb

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 26, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 26, 2025
@nix-owners nix-owners bot requested a review from dvcorreia October 26, 2025 00:09
@iedame
Copy link
Contributor Author

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455671
Commit: 3fa2e51915a5171a591bfb237ee16e5bc93a6ef7 (subsequent changes)
Merge: 5d1dfb3d1f370e1b79d3eb5721cf25e4669f7eda

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18810284424


x86_64-linux

✅ 1 package built:
  • orthanc-plugin-dicomweb

aarch64-linux

✅ 1 package built:
  • orthanc-plugin-dicomweb

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@dvcorreia
Copy link
Member

TBH I'm not very familiar with cmake and building C++ projects
@drupol may be able to review this better 🙇

@dvcorreia dvcorreia requested a review from drupol October 26, 2025 18:25
Copy link
Contributor

@drupol drupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@drupol drupol enabled auto-merge October 26, 2025 18:29
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 26, 2025
@drupol drupol added this pull request to the merge queue Oct 26, 2025
Merged via the queue into NixOS:master with commit d9710bb Oct 26, 2025
32 of 34 checks passed
@iedame iedame deleted the cmake4/orthanc-plugin-dicomweb branch October 30, 2025 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants