Skip to content

trilinos: 12.12.1 -> 16.1.0#455656

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:trilinos
Oct 26, 2025
Merged

trilinos: 12.12.1 -> 16.1.0#455656
dotlambda merged 1 commit intoNixOS:masterfrom
dotlambda:trilinos

Conversation

@dotlambda
Copy link
Member

@dotlambda dotlambda commented Oct 25, 2025

Diff: trilinos/Trilinos@trilinos-release-12-12-1...trilinos-release-16-1-0

related: #445447, #451447 (comment)

Note that xyce is still broken but at least trilinos builds.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from qbisi October 25, 2025 22:27
@dotlambda dotlambda mentioned this pull request Oct 25, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 25, 2025
@nix-owners nix-owners bot requested a review from fedeinthemix October 25, 2025 22:32
@iedame
Copy link
Contributor

iedame commented Oct 26, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455656
Commit: 5d528a08e7f2e8b2079dfe7f6eb7cf3d4e75c57a (subsequent changes)
Merge: 8487a84487b9577c910302c08c762dd412f760b0

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18809329483

x86_64-linux

❌ 4 packages failed to build:
  • xyce
  • xyce-parallel
  • xyce-parallel.doc
  • xyce.doc
✅ 2 packages built:
  • trilinos
  • trilinos-mpi
Error logs: `x86_64-linux`
xyce 
checking for uname... yes
checking for amd_valid in -lamd... yes
checking for main in -lteuchoscore... yes
configure: WARNING: Unable to find export file: Makefile.export.Teuchos.  Using predefined library dependencies.
checking for main in -lteuchoscore... (cached) yes
checking for main in -lteuchosremainder... yes
checking for main in -lteuchosnumerics... yes
checking for main in -lteuchoscomm... yes
checking for main in -lteuchosparameterlist... yes
checking for trilinos_klu_defaults in -ltrilinosss... yes
configure: WARNING: Unable to find export file: Makefile.export.Triutils.  Using predefined library dependencies.
checking for main in -ltriutils... yes
configure: WARNING: Unable to find export file: Makefile.export.Epetra.  Using predefined library dependencies.
checking for main in -lepetra... yes
configure: WARNING: Unable to find export file: Makefile.export.EpetraExt.  Using predefined library dependencies.
checking for main in -lepetraext... yes
checking for g++ -std=gnu++11 options needed to detect all undeclared functions... none needed
checking whether HAVE_TEUCHOS_COMPLEX is declared... yes
checking for Teuchos_SerialDenseMatrix.hpp... no
configure: error: Unable to compile a test program against Trilinos that includes Teuchos_Serial_DenseMatrix.hpp.  It is possible Trilinos was not properly configured or the environment has changed since Trilinos was installed.  See config.log for more information.
xyce-parallel 
checking for library containing MPI_Bcast... none required
checking for amd_valid in -lamd... yes
checking for main in -lteuchoscore... yes
configure: WARNING: Unable to find export file: Makefile.export.Teuchos.  Using predefined library dependencies.
checking for main in -lteuchoscore... (cached) yes
checking for main in -lteuchosremainder... yes
checking for main in -lteuchosnumerics... yes
checking for main in -lteuchoscomm... yes
checking for main in -lteuchosparameterlist... yes
checking for trilinos_klu_defaults in -ltrilinosss... yes
configure: WARNING: Unable to find export file: Makefile.export.Triutils.  Using predefined library dependencies.
checking for main in -ltriutils... yes
configure: WARNING: Unable to find export file: Makefile.export.Epetra.  Using predefined library dependencies.
checking for main in -lepetra... yes
configure: WARNING: Unable to find export file: Makefile.export.EpetraExt.  Using predefined library dependencies.
checking for main in -lepetraext... yes
checking for mpicxx -std=gnu++11 options needed to detect all undeclared functions... none needed
checking whether HAVE_TEUCHOS_COMPLEX is declared... yes
checking for Teuchos_SerialDenseMatrix.hpp... no
configure: error: Unable to compile a test program against Trilinos that includes Teuchos_Serial_DenseMatrix.hpp.  It is possible Trilinos was not properly configured or the environment has changed since Trilinos was installed.  See config.log for more information.

aarch64-linux

✅ 2 packages built:
  • trilinos
  • trilinos-mpi

x86_64-darwin (sandbox = true)

✅ 2 packages built:
  • trilinos
  • trilinos-mpi

aarch64-darwin (sandbox = true)

✅ 2 packages built:
  • trilinos
  • trilinos-mpi

@qbisi
Copy link
Contributor

qbisi commented Oct 26, 2025 •
edited
Loading

I think xyce should switch to cmake build system in align.

trilinos has ref to stdenv.cc and binutils, which make the final closure lagre, we should nuk-ref them.
trilinos has so many component that might be silently enabled/disabled, we should find a generic way decide which components are commonly needed. Also, it has many tpl (third party libraries) dependencies that might optionally affect it's components functionality.

Ref:

  1. debian: https://sources.debian.org/src/trilinos/16.1.0-2/debian/rules#L89-L190
  2. petsc: https://gitlab.com/petsc/petsc/-/blob/main/config/BuildSystem/config/packages/Trilinos.py?ref_type=heads
  3. spack: https://github.com/spack/spack-packages/blob/develop/repos/spack_repo/builtin/packages/trilinos/package.py

@dotlambda
Copy link
Member Author

dotlambda commented Oct 26, 2025

@qbisi Feel free to open your own PR. I don't use this package. The only motivation was fixing the build.

iedame
iedame approved these changes Oct 26, 2025
View reviewed changes
Copy link
Contributor

@iedame iedame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 26, 2025
@qbisi
Copy link
Contributor

qbisi commented Oct 26, 2025

@qbisi Feel free to open your own PR. I don't use this package. The only motivation was fixing the build.

I will try before 25.11 release. This pr LGTM as a fixup, for now, the main block is downstream xyce (we should use cmake to build xyce too).

@dotlambda dotlambda added this pull request to the merge queue Oct 26, 2025
Merged via the queue into NixOS:master with commit 2cfc5bd Oct 26, 2025
29 of 33 checks passed
@dotlambda dotlambda deleted the trilinos branch October 26, 2025 13:46
@iedame iedame mentioned this pull request Oct 26, 2025
Merged
14 tasks
@fedeinthemix
Copy link
Contributor

fedeinthemix commented Oct 27, 2025

Hey, effectively this package is only used by Xyce which requires a specific version of trilinos. It was not updated to the latest for this reason. Please reverse the commit!

@fedeinthemix
Copy link
Contributor

fedeinthemix commented Oct 27, 2025

It would also be polite to wait a couple of days to get feedback from the maintainer...

@qbisi
Copy link
Contributor

qbisi commented Oct 27, 2025 •
edited
Loading

I will try before 25.11 release. This pr LGTM as a fixup, for now, the main block is downstream xyce (we should use cmake to build xyce too).

To clarify:

In fact, i agree with updating/unpin trilinos, but we should not break xyce.

If cant, either use a simple cmake minimual version substitution or mark trilinos broken.

The best solution is to switch xyce build system to cmake, so xyce can find trilinos components. However, we should not enforce that on the maintainer.

@dotlambda
Copy link
Member Author

dotlambda commented Oct 27, 2025 •
edited
Loading

As I said above, trilinos and xyce were both broken before this PR. So this is a strict improvement.

@fedeinthemix
Copy link
Contributor

fedeinthemix commented Oct 27, 2025

Have you checked the upper trilinos supported by latest Xyce? Maybe we'll need a downgrade of the former.

@iedame
Copy link
Contributor

iedame commented Oct 27, 2025 •
edited
Loading

The current minimum version of Trilinos usable in a CMake-configured Xyce is 14.4. Versions after 16.1 have not been rigorously tested with Xyce and may not work properly.

As per https://github.com/Xyce/Xyce/blob/master/INSTALL.md
So this package should be compatible with xyce. Next xyce version will require CMake so updating xyce is inevitable.

@iedame iedame mentioned this pull request Nov 4, 2025
Merged
13 tasks
@fedeinthemix fedeinthemix mentioned this pull request Dec 5, 2025
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qbisi qbisi Awaiting requested review from qbisi

@fedeinthemix fedeinthemix Awaiting requested review from fedeinthemix

1 more reviewer

@iedame iedame iedame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dotlambda @iedame @qbisi @fedeinthemix