Skip to content

nanodbc: fix build with cmake4, mark as broken on darwin#455607

Merged
pyrox0 merged 2 commits intoNixOS:masterfrom
iedame:cmake4/nanodbc-
Oct 27, 2025
Merged

nanodbc: fix build with cmake4, mark as broken on darwin#455607
pyrox0 merged 2 commits intoNixOS:masterfrom
iedame:cmake4/nanodbc-

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 25, 2025 •
edited
Loading

Marking as broken on darwin:
https://hydra.nixos.org/build/310614011

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 25, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 25, 2025
@nix-owners nix-owners bot requested a review from bzizou October 25, 2025 18:48
@iedame

This comment was marked as outdated.

Sign in to view
@iedame iedame changed the title nanodbc: fix build with cmake4 nanodbc: fix build with cmake4, mark as broken on darwin Oct 25, 2025
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 25, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455607
Commit: b466f5f870f891b40399ca394f48e73adb21f819 (subsequent changes)
Merge: f7ccae4db300650ecf88b81e6f11e0a097ac30ba

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18807246059

x86_64-linux

❌ 2 packages failed to build:
  • irods
  • irods-icommands
✅ 1 package built:
  • nanodbc

aarch64-linux

❌ 2 packages failed to build:
  • irods
  • irods-icommands
✅ 1 package built:
  • nanodbc

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

irods and irods-icommands can be fixed in a separate PR.

bzizou
bzizou approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@bzizou bzizou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, so let's fix irods in another PR

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 27, 2025
@bzizou bzizou mentioned this pull request Oct 27, 2025
Merged
13 tasks
@pyrox0 pyrox0 added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 4f5a010 Oct 27, 2025
34 of 36 checks passed
@iedame iedame deleted the cmake4/nanodbc- branch October 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bzizou bzizou bzizou approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @bzizou @pyrox0