Skip to content

nanotts: fix build with cmake4, unbreak#455595

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
iedame:cmake4/nanotts
Nov 4, 2025
Merged

nanotts: fix build with cmake4, unbreak#455595
leona-ya merged 1 commit intoNixOS:masterfrom
iedame:cmake4/nanotts

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 25, 2025

This PR also attempts to unbreak the package, its last successful build on Hydra was in 2024:
https://hydra.nixos.org/build/310418412

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 25, 2025
@nix-owners nix-owners bot requested a review from strikerlulu October 25, 2025 18:02
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455595
Commit: 54f2481d3d74f61162a86cf94b0cd77683519f9a (subsequent changes)
Merge: 9886f594fa6494e9a02c9af9595e854295dbc4e5

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18806535318


x86_64-linux

✅ 1 package built:
  • nanotts

aarch64-linux

✅ 1 package built:
  • nanotts

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@iedame iedame closed this Nov 4, 2025
@iedame iedame reopened this Nov 4, 2025
@iedame iedame requested a review from leona-ya November 4, 2025 18:41
@leona-ya leona-ya added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NixOS:master with commit 8f55c9a Nov 4, 2025
51 of 56 checks passed
@iedame iedame deleted the cmake4/nanotts branch November 4, 2025 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants