Skip to content

monosat: fix build with cmake4#455590

Merged
leona-ya merged 1 commit intoNixOS:masterfrom
iedame:cmake4/monosat
Nov 4, 2025
Merged

monosat: fix build with cmake4#455590
leona-ya merged 1 commit intoNixOS:masterfrom
iedame:cmake4/monosat

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 25, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 25, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 25, 2025
@nix-owners nix-owners bot requested a review from acairncross October 25, 2025 17:44
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455590
Commit: 89420eeaa15c6b5cab9d4058166db6020fbbbe56 (subsequent changes)
Merge: db472cb8e410041c79f7e4596622d23ddd2b78cd

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18806415640

x86_64-linux

❌ 4 packages failed to build:
  • python312Packages.monosat
  • python312Packages.monosat.dist
  • python313Packages.monosat
  • python313Packages.monosat.dist
✅ 1 package built:
  • monosat
Error logs: `x86_64-linux`
python312Packages.monosat 
def addBinaryClause( S ,  lit1 ,  lit2 ):
    """Cython signature: bint addBinaryClause(void* S, int lit1, int lit2)"""

assert isinstance(lit1, (int, long)), 'arg lit1 wrong type'
                              ^





monosat/monosat_p.pyx:174:34: undeclared name not builtin: long

Traceback (most recent call last):

File "/build/source/src/monosat/api/python/nix_run_setup", line 8, in <module>

exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))

File "setup.py", line 91, in <module>

ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/nix/store/s857kqbrwws54bcm5h4q80l4mgxmhh5k-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize

cythonize_one(*args)

File "/nix/store/s857kqbrwws54bcm5h4q80l4mgxmhh5k-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one

raise CompileError(None, pyx_file)

Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

python313Packages.monosat 
  File "/build/source/src/monosat/api/python/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "setup.py", line 91, in <module>
    ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],
                ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     include_dirs=[".", package_dir, package_dir + "/monosat", monosat_path],
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     libraries=["monosat"],
                                     ^^^^^^^^^^^^^^^^^^^^^^
                                     language="c", extra_compile_args=["-DNDEBUG", "-O3"]
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     )], include_path=[package_dir, package_dir + "/monosat"], gdb_debug=True),
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/y72mmp3vzfskqdhg70jrhpb2dfz3g0ni-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize
    cythonize_one(*args)
    ~~~~~~~~~~~~~^^^^^^^
  File "/nix/store/y72mmp3vzfskqdhg70jrhpb2dfz3g0ni-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

aarch64-linux

❌ 4 packages failed to build:
  • python312Packages.monosat
  • python312Packages.monosat.dist
  • python313Packages.monosat
  • python313Packages.monosat.dist
✅ 1 package built:
  • monosat
Error logs: `aarch64-linux`
python312Packages.monosat 
def addBinaryClause( S ,  lit1 ,  lit2 ):
    """Cython signature: bint addBinaryClause(void* S, int lit1, int lit2)"""

assert isinstance(lit1, (int, long)), &#x27;arg lit1 wrong type&#x27;
                              ^





monosat/monosat_p.pyx:174:34: undeclared name not builtin: long

Traceback (most recent call last):

File "/build/source/src/monosat/api/python/nix_run_setup", line 8, in <module>

exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))

File "setup.py", line 91, in <module>

ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/nix/store/fd603dz6gh12mxrza1f4lm3pqp4jgfbg-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize

cythonize_one(*args)

File "/nix/store/fd603dz6gh12mxrza1f4lm3pqp4jgfbg-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one

raise CompileError(None, pyx_file)

Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

python313Packages.monosat 
  File "/build/source/src/monosat/api/python/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "setup.py", line 91, in <module>
    ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],
                ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     include_dirs=[".", package_dir, package_dir + "/monosat", monosat_path],
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     libraries=["monosat"],
                                     ^^^^^^^^^^^^^^^^^^^^^^
                                     language="c", extra_compile_args=["-DNDEBUG", "-O3"]
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     )], include_path=[package_dir, package_dir + "/monosat"], gdb_debug=True),
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/jsg0i00rlqfimbpg0642pifx15z6wrch-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize
    cythonize_one(*args)
    ~~~~~~~~~~~~~^^^^^^^
  File "/nix/store/jsg0i00rlqfimbpg0642pifx15z6wrch-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

x86_64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.monosat
  • python312Packages.monosat.dist
  • python313Packages.monosat
  • python313Packages.monosat.dist
✅ 1 package built:
  • monosat
Error logs: `x86_64-darwin`
python312Packages.monosat 
def addBinaryClause( S ,  lit1 ,  lit2 ):
    """Cython signature: bint addBinaryClause(void* S, int lit1, int lit2)"""

assert isinstance(lit1, (int, long)), &#x27;arg lit1 wrong type&#x27;
                              ^





monosat/monosat_p.pyx:174:34: undeclared name not builtin: long

Traceback (most recent call last):

File "/nix/build/nix-13242-3973962235/source/src/monosat/api/python/nix_run_setup", line 8, in <module>

exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))

File "setup.py", line 91, in <module>

ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/nix/store/6x942qs697r2qvby07r53izkh0ga7vgd-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize

cythonize_one(*args)

File "/nix/store/6x942qs697r2qvby07r53izkh0ga7vgd-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one

raise CompileError(None, pyx_file)

Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

python313Packages.monosat 
  File "/nix/build/nix-13242-3973962236/source/src/monosat/api/python/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "setup.py", line 91, in <module>
    ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],
                ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     include_dirs=[".", package_dir, package_dir + "/monosat", monosat_path],
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     libraries=["monosat"],
                                     ^^^^^^^^^^^^^^^^^^^^^^
                                     language="c", extra_compile_args=["-DNDEBUG", "-O3"]
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     )], include_path=[package_dir, package_dir + "/monosat"], gdb_debug=True),
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/wizjjyflmx71h66vdqjsjxachqap50s1-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize
    cythonize_one(*args)
    ~~~~~~~~~~~~~^^^^^^^
  File "/nix/store/wizjjyflmx71h66vdqjsjxachqap50s1-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

aarch64-darwin (sandbox = true)

❌ 4 packages failed to build:
  • python312Packages.monosat
  • python312Packages.monosat.dist
  • python313Packages.monosat
  • python313Packages.monosat.dist
✅ 1 package built:
  • monosat
Error logs: `aarch64-darwin`
python312Packages.monosat 
def addBinaryClause( S ,  lit1 ,  lit2 ):
    """Cython signature: bint addBinaryClause(void* S, int lit1, int lit2)"""

assert isinstance(lit1, (int, long)), &#x27;arg lit1 wrong type&#x27;
                              ^





monosat/monosat_p.pyx:174:34: undeclared name not builtin: long

Traceback (most recent call last):

File "/nix/build/nix-23950-1212782470/source/src/monosat/api/python/nix_run_setup", line 8, in <module>

exec(compile(getattr(tokenize, 'open', open)(file).read().replace('\r\n', '\n'), file, 'exec'))

File "setup.py", line 91, in <module>

ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],

^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

File "/nix/store/z1hcr7skc9zpdk4kvlv2gbdn7g7lwwrd-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize

cythonize_one(*args)

File "/nix/store/z1hcr7skc9zpdk4kvlv2gbdn7g7lwwrd-python3.12-cython-3.1.4/lib/python3.12/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one

raise CompileError(None, pyx_file)

Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

python313Packages.monosat 
  File "/nix/build/nix-23950-1212782471/source/src/monosat/api/python/nix_run_setup", line 8, in <module>
    exec(compile(getattr(tokenize, 'open', open)(__file__).read().replace('\\r\\n', '\\n'), __file__, 'exec'))
    ~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "setup.py", line 91, in <module>
    ext_modules=cythonize([Extension("monosat.monosat_p", [package_dir + "/monosat/monosat_p.pyx"],
                ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     include_dirs=[".", package_dir, package_dir + "/monosat", monosat_path],
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     libraries=["monosat"],
                                     ^^^^^^^^^^^^^^^^^^^^^^
                                     language="c", extra_compile_args=["-DNDEBUG", "-O3"]
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
                                     )], include_path=[package_dir, package_dir + "/monosat"], gdb_debug=True),
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/ivlb817c3w105xzmic5m0i0p26zf1jfa-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1159, in cythonize
    cythonize_one(*args)
    ~~~~~~~~~~~~~^^^^^^^
  File "/nix/store/ivlb817c3w105xzmic5m0i0p26zf1jfa-python3.13-cython-3.1.4/lib/python3.13/site-packages/Cython/Build/Dependencies.py", line 1303, in cythonize_one
    raise CompileError(None, pyx_file)
Cython.Compiler.Errors.CompileError: ./monosat/monosat_p.pyx

@iedame iedame marked this pull request as draft October 25, 2025 17:59
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025 •
edited
Loading

The Python derivations should be fine, as the underlying issues are currently being addressed in #426471

@iedame iedame marked this pull request as ready for review October 25, 2025 18:32
@iedame iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025
@leona-ya leona-ya added this pull request to the merge queue Nov 4, 2025
Merged via the queue into NixOS:master with commit 81b9e16 Nov 4, 2025
34 of 35 checks passed
@iedame iedame deleted the cmake4/monosat branch November 4, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leona-ya leona-ya leona-ya approved these changes

@acairncross acairncross Awaiting requested review from acairncross

Assignees

No one assigned

Labels

0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @leona-ya