djv: 2.0.8-unstable-2021-07-31 -> 3.1.1 by yzx9 · Pull Request #455551 · NixOS/nixpkgs

yzx9 · 2025-10-25T13:50:13Z

djv has outdated and broken with CMake 4: https://hydra.nixos.org/build/310538595
drop opencolorio_1

Tracking: #445447

close #426523

close #455325

Things done

Add a 👍 reaction to pull requests you find important.

yzx9 · 2025-10-25T14:59:09Z

`nixpkgs-review` result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455551
Commit: 59556e196494a3b72aa1181cf2d9bb94f8e3bdc2 (subsequent changes)
Merge: b7e171db75c3cf14282a661d2c8d3588397f733d

Logs: https://github.com/yzx9/nixpkgs-review-gha/actions/runs/18804538852

`x86_64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`aarch64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`x86_64-darwin` (sandbox = true)

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

`aarch64-darwin` (sandbox = true)

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

yzx9 · 2025-10-27T03:32:07Z

Resolve conflicts

yzx9 · 2025-10-27T03:43:21Z

@luzpaz @liberodark I’d appreciate a review from you, as you were the issue submitter / a recent committer.

liberodark

Diff LGTM

liberodark · 2025-10-29T16:13:16Z

Hi,

Good job this look good to me.
But you can rebase your PR ?
Also you have try djv ?

Also can you change for tlrender :

 # doCheck = enableTests;
  #
  # nativeCheckInputs = lib.optionals (enableTests && stdenv.isLinux) [
  #   xorg.xvfb-run
  # ];
  #
  # checkPhase = lib.optionalString enableTests ''
  #   runHook preCheck
  #
  #   cd feather-tk/src/feather-tk-build
  #   ${if stdenv.isLinux then "xvfb-run" else ""} ctest --verbose -C Release
  #
  #   runHook postCheck
  # '';

@GaetanLepage can you make a review when you have time ?

Best Regards

GaetanLepage · 2025-10-29T21:15:34Z

Git conflict.

pkgs/by-name/fe/feather-tk/package.nix

pkgs/by-name/dj/djv/package.nix

pkgs/by-name/tl/tlrender/package.nix

GaetanLepage · 2025-10-31T09:03:57Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455551
Commit: 4a9128ca699bf2b122874f34941852dc646095f3

`x86_64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`aarch64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`x86_64-darwin`

❌ 3 packages failed to build:

djv
feather-tk
tlrender

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

`aarch64-darwin`

❌ 3 packages failed to build:

djv
feather-tk
tlrender

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

Error logs: `x86_64-darwin`

feather-tk

      | ^
/nix/var/nix/builds/nix-24025-183988086/source/lib/feather-tk/core/FileUnix.cpp:38:9: warning: 'FSRefMakePath' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
   38 |         FSRefMakePath(&ref, (UInt8*)&path, PATH_MAX);
      |         ^
/nix/store/4mn3pvf8ahm21qjdh4r2w1lf90gcv9yq-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Files.h:4086:18: note: 'FSRefMakePath' has been explicitly marked deprecated here
 4086 | extern OSStatus  FSRefMakePath(const FSRef *ref, UInt8 *path, UInt32 pathBufferSize)     __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA);
      |                  ^
2 warnings generated.
[ 60%] Building CXX object lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/TimeUnix.cpp.o
[ 60%] Linking CXX shared library libfeather-tk-core.dylib
Undefined symbols for architecture x86_64:
  "_FSFindFolder", referenced from:
      feather_tk::getUserPath(feather_tk::UserPath) in FileUnix.cpp.o
  "_FSRefMakePath", referenced from:
      feather_tk::getUserPath(feather_tk::UserPath) in FileUnix.cpp.o
ld: symbol(s) not found for architecture x86_64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/build.make:728: lib/feather-tk/core/libfeather-tk-core.dylib] Error 1
make[1]: *** [CMakeFiles/Makefile2:304: lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

Error logs: `aarch64-darwin`

feather-tk

      | ^
/nix/var/nix/builds/nix-22086-816052136/source/lib/feather-tk/core/FileUnix.cpp:38:9: warning: 'FSRefMakePath' is deprecated: first deprecated in macOS 10.8 [-Wdeprecated-declarations]
   38 |         FSRefMakePath(&ref, (UInt8*)&path, PATH_MAX);
      |         ^
/nix/store/ybygcq3s191f07bwgxbqpgqv0ak4h17k-apple-sdk-11.3/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/Files.h:4086:18: note: 'FSRefMakePath' has been explicitly marked deprecated here
 4086 | extern OSStatus  FSRefMakePath(const FSRef *ref, UInt8 *path, UInt32 pathBufferSize)     __OSX_AVAILABLE_BUT_DEPRECATED(__MAC_10_0, __MAC_10_8, __IPHONE_NA, __IPHONE_NA);
      |                  ^
2 warnings generated.
[ 60%] Building CXX object lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/TimeUnix.cpp.o
[ 60%] Linking CXX shared library libfeather-tk-core.dylib
Undefined symbols for architecture arm64:
  "_FSFindFolder", referenced from:
      feather_tk::getUserPath(feather_tk::UserPath) in FileUnix.cpp.o
  "_FSRefMakePath", referenced from:
      feather_tk::getUserPath(feather_tk::UserPath) in FileUnix.cpp.o
ld: symbol(s) not found for architecture arm64
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/build.make:728: lib/feather-tk/core/libfeather-tk-core.dylib] Error 1
make[1]: *** [CMakeFiles/Makefile2:304: lib/feather-tk/core/CMakeFiles/feather-tk-core.dir/all] Error 2
make: *** [Makefile:136: all] Error 2

yzx9 · 2025-10-31T09:40:07Z

feather-tk was broken on darwin (grizzlypeak3d/feather-tk#1)

GaetanLepage · 2025-10-31T21:41:09Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455551
Commit: 8280a272060111fb8fe91552884d5839706035f8

`x86_64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`aarch64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`x86_64-darwin`

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

`aarch64-darwin`

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

pkgs/by-name/tl/tlrender/package.nix

pkgs/by-name/na/nativefiledialog-extended/package.nix

pkgs/by-name/fe/feather-tk/package.nix

GaetanLepage · 2025-11-03T10:35:21Z

pkgs/by-name/fe/feather-tk/package.nix

+    # Broken on darwin with latest SDK, see https://github.com/darbyjohnston/feather-tk/issues/1
+    broken = stdenv.hostPlatform.isDarwin;


Suggested change

# Broken on darwin with latest SDK, see https://github.com/darbyjohnston/feather-tk/issues/1

broken = stdenv.hostPlatform.isDarwin;

badPlatforms = [

# Broken on darwin with latest SDK, see https://github.com/darbyjohnston/feather-tk/issues/1

lib.systems.inspect.patterns.isDarwin

];

I think it’s only temporarily unbuildable, since the issue has actually been fixed. However, because the code has changed significantly, the patch probably can’t be applied directly (if anyone’s interested, feel free to backport it).

But it’s clear that we can resolve this in the next release, so I prefer to mark it as broken for now.

Sorry, I didn't explain myself.
Adding "broken" platforms to badPlatforms is preferable compared to setting broken = isDarwin.
The error message is slightly more helpful.
The fact that it is only temporary does not change my initial suggestion.

Thanks for your explanation! I've applied your suggestion.

GaetanLepage · 2025-11-03T14:01:04Z

pkgs/by-name/fe/feather-tk/package.nix

@@ -93,5 +94,9 @@ stdenv.mkDerivation (finalAttrs: {
    license = lib.licenses.bsd3;
    maintainers = with lib.maintainers; [ liberodark ];
    platforms = lib.platforms.linux ++ lib.platforms.darwin;
+    badPlatforms = [
+      # Broken on darwin with latest SDK, see https://github.com/darbyjohnston/feather-tk/issues/1
+      stdenv.hostPlatform.isDarwin


Suggested change

stdenv.hostPlatform.isDarwin

lib.systems.inspect.patterns.isDarwin

Good catch! I never knew there was such an option.

GaetanLepage · 2025-11-04T09:16:47Z

`nixpkgs-review` result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 455551
Commit: 859e4771871bf8b263be8ebc22f5b2d306877793

`x86_64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`aarch64-linux`

✅ 5 packages built:

djv
feather-tk
nativefiledialog-extended
nativefiledialog-extended.dev
tlrender

`x86_64-darwin`

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

`aarch64-darwin`

✅ 2 packages built:

nativefiledialog-extended
nativefiledialog-extended.dev

GaetanLepage

Well done @yzx9!
I force pushed a change in tlrender's description (removal of the "An" at the beginning), see https://nixos.org/manual/nixpkgs/unstable/#var-meta-description.

nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 25, 2025

iedame mentioned this pull request Oct 25, 2025

Tracking: Build Failures with CMake 4 #445447

Open

yzx9 force-pushed the djv-3-1-1 branch from a64251f to 9307dcd Compare October 25, 2025 14:13

yzx9 requested a review from liberodark October 25, 2025 14:30

This comment was marked as outdated.

Sign in to view

yzx9 force-pushed the djv-3-1-1 branch from e38da2b to 59556e1 Compare October 25, 2025 14:45

nixpkgs-ci bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Oct 25, 2025

yzx9 marked this pull request as ready for review October 25, 2025 14:59

nix-owners bot requested a review from blitz October 25, 2025 15:00

iedame mentioned this pull request Oct 25, 2025

opencolorio_1: fix build with cmake4, yaml-cpp_0_3: init at 0.3.0 #455325

Closed

13 tasks

yzx9 force-pushed the djv-3-1-1 branch from 59556e1 to 2527ff2 Compare October 27, 2025 03:29

liberodark approved these changes Oct 29, 2025

View reviewed changes

liberodark requested a review from GaetanLepage October 29, 2025 16:11

yzx9 added 3 commits October 30, 2025 09:32

nativefiledialog-extended: init at 1.2.1

68ed260

feather-tk: use nativefiledialog-extended by default

3ecdb07

feather-tk: build shared libs

c84307e

yzx9 force-pushed the djv-3-1-1 branch from 2527ff2 to 79ee66d Compare October 30, 2025 01:32

nixpkgs-ci bot removed 2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. labels Oct 30, 2025

GaetanLepage reviewed Oct 30, 2025

View reviewed changes

pkgs/by-name/fe/feather-tk/package.nix Show resolved Hide resolved

pkgs/by-name/dj/djv/package.nix Outdated Show resolved Hide resolved

pkgs/by-name/tl/tlrender/package.nix Outdated Show resolved Hide resolved

yzx9 force-pushed the djv-3-1-1 branch from 79ee66d to 67b28e3 Compare October 31, 2025 03:15

yzx9 force-pushed the djv-3-1-1 branch from 67b28e3 to 4a9128c Compare October 31, 2025 03:22

yzx9 force-pushed the djv-3-1-1 branch from 4a9128c to 8280a27 Compare October 31, 2025 09:42

nixpkgs-ci bot added the 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. label Oct 31, 2025

GaetanLepage reviewed Oct 31, 2025

View reviewed changes

pkgs/by-name/tl/tlrender/package.nix Show resolved Hide resolved

pkgs/by-name/tl/tlrender/package.nix Outdated Show resolved Hide resolved

yzx9 force-pushed the djv-3-1-1 branch 2 times, most recently from ebb98f2 to 7fb5e40 Compare November 3, 2025 06:37

GaetanLepage reviewed Nov 3, 2025

View reviewed changes

yzx9 force-pushed the djv-3-1-1 branch 2 times, most recently from d47b0e8 to acd72aa Compare November 3, 2025 12:33

GaetanLepage reviewed Nov 3, 2025

View reviewed changes

feather-tk: mark darwin as bad platform

3d989ea

yzx9 force-pushed the djv-3-1-1 branch from acd72aa to 859e477 Compare November 4, 2025 02:27

yzx9 added 2 commits November 4, 2025 09:18

tlrender: init at 0.10.0

01c9507

djv: 2.0.8-unstable-2021-07-31 -> 3.1.1

99103b0

GaetanLepage force-pushed the djv-3-1-1 branch from 859e477 to 99103b0 Compare November 4, 2025 09:18

GaetanLepage approved these changes Nov 4, 2025

View reviewed changes

nixpkgs-ci bot added 12.approvals: 2 This PR was reviewed and approved by two persons. and removed 12.approvals: 1 This PR was reviewed and approved by one person. labels Nov 4, 2025

GaetanLepage added this pull request to the merge queue Nov 4, 2025

Merged via the queue into NixOS:master with commit eefbcd1 Nov 4, 2025
28 of 32 checks passed

yzx9 deleted the djv-3-1-1 branch November 4, 2025 09:58

Sigmanificient mentioned this pull request Jan 3, 2026

opencolorio_1: drop #476667

Merged

13 tasks

		# Broken on darwin with latest SDK, see https://github.com/darbyjohnston/feather-tk/issues/1
		broken = stdenv.hostPlatform.isDarwin;

	stdenv.hostPlatform.isDarwin
	lib.systems.inspect.patterns.isDarwin

Uh oh!

Conversation

yzx9 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Things done

Uh oh!

This comment was marked as outdated.

yzx9 commented Oct 25, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin (sandbox = true)

aarch64-darwin (sandbox = true)

Uh oh!

yzx9 commented Oct 27, 2025

Uh oh!

yzx9 commented Oct 27, 2025

Uh oh!

liberodark left a comment

Choose a reason for hiding this comment

Uh oh!

liberodark commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

GaetanLepage commented Oct 29, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaetanLepage commented Oct 31, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

yzx9 commented Oct 31, 2025

Uh oh!

GaetanLepage commented Oct 31, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GaetanLepage Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

yzx9 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

GaetanLepage Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

yzx9 Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

GaetanLepage Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

yzx9 Nov 4, 2025

Choose a reason for hiding this comment

Uh oh!

GaetanLepage commented Nov 4, 2025

nixpkgs-review result

x86_64-linux

aarch64-linux

x86_64-darwin

aarch64-darwin

Uh oh!

GaetanLepage left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

yzx9 commented Oct 25, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin` (sandbox = true)

`aarch64-darwin` (sandbox = true)

liberodark commented Oct 29, 2025 •

edited

Loading

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`

`nixpkgs-review` result

`x86_64-linux`

`aarch64-linux`

`x86_64-darwin`

`aarch64-darwin`