Skip to content

qscreenshot: fix build with cmake4#455531

Merged
bjornfor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/qscreenshot
Oct 25, 2025
Merged

qscreenshot: fix build with cmake4#455531
bjornfor merged 1 commit intoNixOS:masterfrom
iedame:cmake4/qscreenshot

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 25, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 25, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Oct 25, 2025
@nix-owners nix-owners bot requested a review from bjornfor October 25, 2025 12:49
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455531
Commit: ec3410f6b768c8ec9388cd7c8e1adf222b7279cb (subsequent changes)
Merge: 9036dda3a151a6c9c6d29addcb8cc642e6fde06a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18803284364

x86_64-linux

✅ 1 package built:
  • qscreenshot

aarch64-linux

✅ 1 package built:
  • qscreenshot

x86_64-darwin (sandbox = true)

❌ 1 package failed to build:
  • qscreenshot

aarch64-darwin (sandbox = true)

❌ 1 package failed to build:
  • qscreenshot

@bjornfor bjornfor added this pull request to the merge queue Oct 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 25, 2025
Merged via the queue into NixOS:master with commit 36576a1 Oct 25, 2025
32 of 36 checks passed
@iedame iedame deleted the cmake4/qscreenshot branch October 25, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @bjornfor