tora: fix build with cmake4, mark as broken by iedame · Pull Request #455510 · NixOS/nixpkgs

iedame · 2025-10-25T11:30:25Z

Tracking: Build Failures with CMake 4 #445447

It starts building but fails due to various errors, last successful build on Hydra was 2024-12-02 21:05:44:
https://hydra.nixos.org/build/296255150

Things done

Add a 👍 reaction to pull requests you find important.

peterhoeg · 2025-10-27T20:34:18Z

We can make it build (and run):

add this above:

let
  dtl = fetchFromGitHub {
    owner = "cubicdaiya";
    repo = "dtl";
    tag = "v1.21";
    hash = "sha256-s+syRiJhcxvmE0FBcbCi6DrL1hwu+0IJNMgg5Tldsv4=";
  };

in

and then in `postPatch':

    rm -rf extlibs/dtl
    ln -s ${dtl} extlibs/dtl

iedame · 2025-10-27T21:07:42Z

@peterhoeg Thank you Peter! I tested your suggestion but it still failed, any ideas why? I just removed the broken = true; and added your suggested dtl let in at top in the usual place and the other part in postPatch.

/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:509:107: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  509 |         toCacheEntryFunction(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                           ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:509:107: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  509 |         toCacheEntryFunction(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                           ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:517:106: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  517 |         toCacheEntryPackage(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                          ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:517:106: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  517 |         toCacheEntryPackage(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                          ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:525:110: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  525 |         toCacheEntryPackageBody(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                              ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:525:110: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  525 |         toCacheEntryPackageBody(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                              ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:533:104: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  533 |         toCacheEntryIndex(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                        ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:533:104: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  533 |         toCacheEntryIndex(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                        ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:541:107: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  541 |         toCacheEntrySequence(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                           ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:541:107: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  541 |         toCacheEntrySequence(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                           ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:549:106: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  549 |         toCacheEntryTrigger(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                          ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:549:106: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  549 |         toCacheEntryTrigger(const QString &owner, const QString &name, const QString &comment = QString::null);
      |                                                                                                          ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:557:85: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  557 |         toCacheEntryDatabase(const QString &name, const QString &comment = QString::null);
      |                                                                                     ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
/build/source/src/core/tocache.h:557:85: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
  557 |         toCacheEntryDatabase(const QString &name, const QString &comment = QString::null);
      |                                                                                     ^~~~
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
  951 |     static const Null null;
      |                       ^~~~
In file included from /build/source/src/editor/tosqltext.h:43:
/build/source/src/parsing/tsqlparse.h: In member function 'const QList<const SQLParser::Token*> SQLParser::Statement::declarations(const QString&) const':
/build/source/src/parsing/tsqlparse.h:725:45: warning: 'QList<T> QMap<K, V>::values(const Key&) const [with Key = QString; T = const SQLParser::Token*]' is deprecated: Use QMultiMap for maps storing multiple values with the same key. [-Wdeprecated-declarations]
  725 |                 return _mDeclarations.values(alias);
      |                        ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
In file included from /nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/QMap:1,
                 from /nix/store/67fq91vwqglpm6pnv7h17amg7p0qqa1g-qscintilla-qt5-2.14.1/include/Qsci/qscilexer.h:26,
                 from /nix/store/67fq91vwqglpm6pnv7h17amg7p0qqa1g-qscintilla-qt5-2.14.1/include/Qsci/qscilexersql.h:27,
                 from /build/source/src/core/tosyntaxanalyzer.h:40:
/nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qmap.h:1360:10: note: declared here
 1360 | QList<T> QMap<Key, T>::values(const Key &key) const
      |          ^~~~~~~~~~~~
make[1]: *** [CMakeFiles/Makefile2:279: src/CMakeFiles/tora.dir/all] Error 2
make: *** [Makefile:156: all] Error 2
error: Cannot build '/nix/store/98g0bga6an5maxblv2zi739nsy9bp70a-tora-3.2.176.drv'.
       Reason: builder failed with exit code 2.
       Output paths:
         /nix/store/df8ikq00nvvlvyi82mcw1c7jyxb0mshi-tora-3.2.176
       Last 25 log lines:
       >   557 |         toCacheEntryDatabase(const QString &name, const QString &comment = QString::null);
       >       |                                                                                     ^~~~
       > /nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
       >   951 |     static const Null null;
       >       |                       ^~~~
       > /build/source/src/core/tocache.h:557:85: warning: 'QString::null' is deprecated: use QString() [-Wdeprecated-declarations]
       >   557 |         toCacheEntryDatabase(const QString &name, const QString &comment = QString::null);
       >       |                                                                                     ^~~~
       > /nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qstring.h:951:23: note: declared here
       >   951 |     static const Null null;
       >       |                       ^~~~
       > In file included from /build/source/src/editor/tosqltext.h:43:
       > /build/source/src/parsing/tsqlparse.h: In member function 'const QList<const SQLParser::Token*> SQLParser::Statement::declarations(const QString&) const':
       > /build/source/src/parsing/tsqlparse.h:725:45: warning: 'QList<T> QMap<K, V>::values(const Key&) const [with Key = QString; T = const SQLParser::Token*]' is deprecated: Use QMultiMap for maps storing multiple values with the same key. [-Wdeprecated-declarations]
       >   725 |                 return _mDeclarations.values(alias);
       >       |                        ~~~~~~~~~~~~~~~~~~~~~^~~~~~~
       > In file included from /nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/QMap:1,
       >                  from /nix/store/67fq91vwqglpm6pnv7h17amg7p0qqa1g-qscintilla-qt5-2.14.1/include/Qsci/qscilexer.h:26,
       >                  from /nix/store/67fq91vwqglpm6pnv7h17amg7p0qqa1g-qscintilla-qt5-2.14.1/include/Qsci/qscilexersql.h:27,
       >                  from /build/source/src/core/tosyntaxanalyzer.h:40:
       > /nix/store/sw2wg770fs685yiwbz051bn1bhnlrgfg-qtbase-5.15.17-dev/include/QtCore/qmap.h:1360:10: note: declared here
       >  1360 | QList<T> QMap<Key, T>::values(const Key &key) const
       >       |          ^~~~~~~~~~~~
       > make[1]: *** [CMakeFiles/Makefile2:279: src/CMakeFiles/tora.dir/all] Error 2
       > make: *** [Makefile:156: all] Error 2
       For full logs, run:
         nix log /nix/store/98g0bga6an5maxblv2zi739nsy9bp70a-tora-3.2.176.drv
➜  nixpkgs git:(cmake4/tora-) ✗

peterhoeg · 2025-10-28T08:06:05Z

Strange, it was working here. I'll take a look tonight.

iedame · 2025-11-04T10:17:14Z

@peterhoeg any news on this one? thank you!

vcunat · 2025-11-08T09:34:44Z

Let's make this the first step, and you can add further changes on top.

tora: fix build with cmake4, mark as broken

ba16421

iedame mentioned this pull request Oct 25, 2025

Tracking: Build Failures with CMake 4 #445447

Open

nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 25, 2025

nix-owners bot requested a review from peterhoeg October 25, 2025 11:35

iedame added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 3, 2025

vcunat added this pull request to the merge queue Nov 8, 2025

Merged via the queue into NixOS:master with commit d39c0bb Nov 8, 2025
32 of 33 checks passed

iedame deleted the cmake4/tora- branch November 8, 2025 10:06

iedame mentioned this pull request Nov 8, 2025

Tracking: Broken ancient packages #459759

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

tora: fix build with cmake4, mark as broken#455510

tora: fix build with cmake4, mark as broken#455510
vcunat merged 1 commit intoNixOS:masterfrom
iedame:cmake4/tora-

iedame commented Oct 25, 2025

Uh oh!

peterhoeg commented Oct 27, 2025

Uh oh!

iedame commented Oct 27, 2025

Uh oh!

peterhoeg commented Oct 28, 2025

Uh oh!

iedame commented Nov 4, 2025

Uh oh!

vcunat commented Nov 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

iedame commented Oct 25, 2025

Things done

Uh oh!

peterhoeg commented Oct 27, 2025

Uh oh!

iedame commented Oct 27, 2025

Uh oh!

peterhoeg commented Oct 28, 2025

Uh oh!

iedame commented Nov 4, 2025

Uh oh!

vcunat commented Nov 8, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants