Skip to content

wayland: add darwin to badPlatforms#455455

Merged
K900 merged 1 commit intoNixOS:masterfrom
Prince213:push-yrsysllqsopz
Oct 25, 2025
Merged

wayland: add darwin to badPlatforms#455455
K900 merged 1 commit intoNixOS:masterfrom
Prince213:push-yrsysllqsopz

Conversation

@Prince213
Copy link
Member

@Prince213 Prince213 commented Oct 25, 2025

Our current approach to broken makes it hard to check if a package is broken on a given platform.

Resolves #455059.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 25, 2025
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Oct 25, 2025
Copy link
Member

@Samasaur1 Samasaur1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fully resolve the linked issue (qtbase and dependents still fail to build on Darwin until I put up the fix I have) but fixes the withWayland check

@Prince213
Copy link
Member Author

Let's fix eval first.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 25, 2025
@K900
Copy link
Contributor

K900 commented Oct 25, 2025

You shouldn't need both badPlatforms and broken.

@K900 K900 enabled auto-merge October 25, 2025 06:21
@K900 K900 added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 6a08e6b Oct 25, 2025
26 of 30 checks passed
@Prince213 Prince213 deleted the push-yrsysllqsopz branch November 25, 2025 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: qtbase - materialgram & telegram-desktop & more packages on darwin

3 participants