Skip to content

t4kcommon: fix build with cmake4#455425

Merged
pyrox0 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/t4kcommon-
Oct 27, 2025
Merged

t4kcommon: fix build with cmake4#455425
pyrox0 merged 1 commit intoNixOS:masterfrom
iedame:cmake4/t4kcommon-

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 25, 2025

This derivation builds successfully on x86_64-linux. I also verified the success by testing the build dependency against tuxtype, which also works as expected.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 25, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 25, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455425
Commit: d2fec8710810c2745f9dcba81ce62a7e9694eb8e (subsequent changes)
Merge: e81ad1e34b08ce990999edb974cd76d2eb4c8c5f

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18797025293

x86_64-linux

✅ 2 packages built:
  • t4kcommon
  • tuxtype

aarch64-linux

✅ 2 packages built:
  • t4kcommon
  • tuxtype

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 25, 2025
mdaniels5757
mdaniels5757 reviewed Oct 25, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's not obvious, patches should have a comment explaining why they are needed.

Otherwise LGTM.

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 25, 2025
@iedame iedame force-pushed the cmake4/t4kcommon- branch from d2fec87 to 7c3095f Compare October 25, 2025 16:04
@iedame @mdaniels5757
t4kcommon: fix build with cmake4
838c1fd 
Co-authored-by: Michael Daniels <[email protected]>
@iedame iedame force-pushed the cmake4/t4kcommon- branch from 7c3095f to 838c1fd Compare October 25, 2025 16:04
@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 25, 2025
@pyrox0 pyrox0 added this pull request to the merge queue Oct 27, 2025
Merged via the queue into NixOS:master with commit 51bc71a Oct 27, 2025
29 of 31 checks passed
@iedame iedame deleted the cmake4/t4kcommon- branch October 27, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iedame @mdaniels5757 @pyrox0