Skip to content

haskellPackages: unconditionally apply GHC patches waiting on upstream developments#455401

Merged
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
alexfmpe:unconditional-patch-ghc
Jan 11, 2026
Merged

haskellPackages: unconditionally apply GHC patches waiting on upstream developments#455401
wolfgangwalther merged 1 commit intoNixOS:haskell-updatesfrom
alexfmpe:unconditional-patch-ghc

Conversation

@alexfmpe
Copy link
Member

@alexfmpe alexfmpe commented Oct 24, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@alexfmpe alexfmpe mentioned this pull request Oct 24, 2025
Merged
13 tasks
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 6.topic: haskell General-purpose, statically typed, purely functional programming language labels Oct 24, 2025
@alexfmpe alexfmpe force-pushed the unconditional-patch-ghc branch from 22d8711 to c136529 Compare October 25, 2025 00:23
wolfgangwalther
wolfgangwalther approved these changes Oct 25, 2025
View reviewed changes
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Oct 25, 2025
@alexfmpe alexfmpe force-pushed the unconditional-patch-ghc branch from c136529 to 2d90c6f Compare October 25, 2025 12:13
wolfgangwalther
wolfgangwalther approved these changes Oct 25, 2025
View reviewed changes
Copy link
Contributor

@wolfgangwalther wolfgangwalther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; did not do any builds.

@alexfmpe alexfmpe force-pushed the unconditional-patch-ghc branch from 2d90c6f to 43cc9f5 Compare January 11, 2026 01:18
@alexfmpe alexfmpe changed the base branch from staging to haskell-updates January 11, 2026 01:19
@nixpkgs-ci nixpkgs-ci bot closed this Jan 11, 2026
@nixpkgs-ci nixpkgs-ci bot reopened this Jan 11, 2026
@alexfmpe
Copy link
Member Author

alexfmpe commented Jan 11, 2026 •
edited
Loading

Changed target to haskell-updates instead of staging. It can be merged in the next branch-off from staging or so

@wolfgangwalther wolfgangwalther added this pull request to the merge queue Jan 11, 2026
Merged via the queue into NixOS:haskell-updates with commit ac40116 Jan 11, 2026
39 of 42 checks passed
@sternenseemann
Copy link
Member

sternenseemann commented Jan 13, 2026

I think patches don't apply for some versions of GHC, please double check on Hydra: https://hydra.nixos.org/eval/1821930#tabs-now-fail

@alexfmpe
Copy link
Member Author

alexfmpe commented Jan 13, 2026 •
edited
Loading

Wow all of them have conflicts on earlier GHC.
This went undetected because I was always using ghc910 or ghc912 for cross builds
#479828

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfgangwalther wolfgangwalther wolfgangwalther approved these changes

@sternenseemann sternenseemann Awaiting requested review from sternenseemann

@maralorn maralorn Awaiting requested review from maralorn

@guibou guibou Awaiting requested review from guibou

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees

No one assigned

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexfmpe @sternenseemann @wolfgangwalther