Skip to content

opencolorio_1: fix build with cmake4, yaml-cpp_0_3: init at 0.3.0#455325

Closed
iedame wants to merge 4 commits intoNixOS:masterfrom
iedame:cmake4/opencolorio_1-
Closed

opencolorio_1: fix build with cmake4, yaml-cpp_0_3: init at 0.3.0#455325
iedame wants to merge 4 commits intoNixOS:masterfrom
iedame:cmake4/opencolorio_1-

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 24, 2025 •
edited
Loading

Edit: Marked as draft to be closed by #455551

Re-introduces yaml-cpp_0_3, that is needed patched for cmake4.

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 24, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 24, 2025
@nix-owners nix-owners bot requested a review from yzx9 October 24, 2025 18:44
@iedame

This comment was marked as outdated.

Sign in to view
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 24, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455325
Commit: 43652160393291c01fbcafe968fd582a0cbc9c04 (subsequent changes)
Merge: c5c2079d0058784414a6756c040dc79d52342c2a

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18789637314

x86_64-linux

❌ 1 package failed to build:
  • djv
✅ 4 packages built:
  • opencolorio_1
  • opencolorio_1.bin
  • opencolorio_1.dev
  • yaml-cpp_0_3

aarch64-linux

❌ 1 package failed to build:
  • djv
✅ 4 packages built:
  • opencolorio_1
  • opencolorio_1.bin
  • opencolorio_1.dev
  • yaml-cpp_0_3

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@iedame
Copy link
Contributor Author

iedame commented Oct 24, 2025

djv can be fixed in a separated PR.

@yzx9
Copy link
Contributor

yzx9 commented Oct 25, 2025 •
edited
Loading

Thank you! I just noticed that opencolorio_1 is broken.

However, since djv is the only package depending on opencolorio_1, and it already supports opencolorio v2.4.2 in v3.2.0, would it make sense to bump djv and drop opencolorio_1?

cc @blitz as the maintainer of djv

@iedame
Copy link
Contributor Author

iedame commented Oct 25, 2025

That is definitely a good approach, instead of reviving yaml-cpp_0_3. We could definitely do that, let's hear from @blitz first.

@yzx9 yzx9 mentioned this pull request Oct 25, 2025
Merged
13 tasks
@iedame iedame marked this pull request as draft October 25, 2025 15:13
@nixpkgs-ci nixpkgs-ci bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Oct 30, 2025
@iedame iedame deleted the cmake4/opencolorio_1- branch November 4, 2025 09:59
@Sigmanificient Sigmanificient mentioned this pull request Jan 3, 2026
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yzx9 yzx9 Awaiting requested review from yzx9

Assignees

No one assigned

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iedame @yzx9