Skip to content

sdl-jstest: 2018-06-15 -> 0.2.2-unstable-2025-03-27#455307

Merged
LordGrimmauld merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-rpnktvnznpnt
Nov 1, 2025
Merged

sdl-jstest: 2018-06-15 -> 0.2.2-unstable-2025-03-27#455307
LordGrimmauld merged 1 commit intoNixOS:masterfrom
marcin-serwin:push-rpnktvnznpnt

Conversation

@marcin-serwin
Copy link
Contributor

@marcin-serwin marcin-serwin commented Oct 24, 2025

Related to: #445447

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 24, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@Sigmanificient
Copy link
Member

Sigmanificient commented Oct 29, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455307
Commit: 67bf5838945fbe9ea2d8202c75d890ba053e1a38 (subsequent changes)
Merge: cbebd6049f1d48c64b2837fcee0c016801fac149

Logs: https://github.com/Sigmanificient/nixpkgs-review-gha/actions/runs/18908992615

x86_64-linux

✅ 1 package built:
  • sdl-jstest

aarch64-linux

✅ 1 package built:
  • sdl-jstest

LordGrimmauld
LordGrimmauld approved these changes Nov 1, 2025
View reviewed changes
Copy link
Contributor

@LordGrimmauld LordGrimmauld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, i am not opposed to merging this as-is.

However: We should consider removing the SDL1 functionality, see also https://github.com/Grumbel/sdl-jstest/blob/917d27b3b45a335137bd2c8597f8bcf2bac8a569/CMakeLists.txt#L29-L30

It makes little sense to build both the sdl1 and sdl2 versions if sdl1 is just the SDL-compat package. I am happy to merge a follow-up along those lines though, for now the cmake fix is probably more relevant.

@LordGrimmauld LordGrimmauld added this pull request to the merge queue Nov 1, 2025
@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Nov 1, 2025
Merged via the queue into NixOS:master with commit 1cda940 Nov 1, 2025
34 of 35 checks passed
@marcin-serwin marcin-serwin mentioned this pull request Nov 1, 2025
Merged
13 tasks
@marcin-serwin marcin-serwin deleted the push-rpnktvnznpnt branch February 3, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LordGrimmauld LordGrimmauld LordGrimmauld approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcin-serwin @Sigmanificient @LordGrimmauld