Skip to content

libsForQt5.qtcurve: fix build with cmake 4#455246

Merged
JohnRTitor merged 1 commit intoNixOS:masterfrom
samestep:qtcurve-cmake4
Oct 25, 2025
Merged

libsForQt5.qtcurve: fix build with cmake 4#455246
JohnRTitor merged 1 commit intoNixOS:masterfrom
samestep:qtcurve-cmake4

Conversation

@samestep
Copy link
Contributor

@samestep samestep commented Oct 24, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@iedame iedame mentioned this pull request Oct 24, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455246 --build-args='-L'
Commit: ded5cbebe1ccc4ad2831c896df7f8ef3063c15f9 (subsequent changes)
Merge: 1ba889e58f1d245a71103af0c4f1f82e91ab9e48

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18793626759

x86_64-linux

✅ 1 package built:
  • libsForQt5.qtcurve (plasma5Packages.qtcurve)

aarch64-linux

✅ 1 package built:
  • libsForQt5.qtcurve (plasma5Packages.qtcurve)

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved automatically following the successful run of nixpkgs-review.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@JohnRTitor JohnRTitor added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 42f6222 Oct 25, 2025
30 of 34 checks passed
@samestep samestep deleted the qtcurve-cmake4 branch November 30, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

@JohnRTitor JohnRTitor JohnRTitor approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samestep @mdaniels5757 @JohnRTitor