Skip to content

libsForQt5.kf5gpgmepp: fix build with cmake 4#455245

Closed
samestep wants to merge 1 commit intoNixOS:masterfrom
samestep:gpgmepp-cmake4
Closed

libsForQt5.kf5gpgmepp: fix build with cmake 4#455245
samestep wants to merge 1 commit intoNixOS:masterfrom
samestep:gpgmepp-cmake4

Conversation

@samestep
Copy link
Contributor

@samestep samestep commented Oct 24, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Oct 24, 2025
@iedame iedame mentioned this pull request Oct 24, 2025
Open
@nixpkgs-ci nixpkgs-ci bot added the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 24, 2025
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455245 --build-args='-L'
Commit: 86c23ca489180451206636d76777dd2448747fdf (subsequent changes)
Merge: 27fc57eae64c9c078087ef06772353cee73b8b18

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18793613070

x86_64-linux

✅ 1 package built:
  • libsForQt5.kf5gpgmepp (plasma5Packages.kf5gpgmepp)

aarch64-linux

✅ 1 package built:
  • libsForQt5.kf5gpgmepp (plasma5Packages.kf5gpgmepp)

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

mdaniels5757
mdaniels5757 reviewed Oct 25, 2025
View reviewed changes
pkgs/development/libraries/kf5gpgmepp/cmake-minimum-required.patch Outdated
+cmake_minimum_required(VERSION 3.10)

-project(Gpgmepp)
+project(Gpgmepp VERSION 16.08.3)
Copy link
Member

@mdaniels5757 mdaniels5757 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the package is updated in the future without a cmake fix, will this cause an incorrect version to appear anywhere?

Copy link
Contributor Author

@samestep samestep Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdaniels5757 the source repository is archived and was last updated in 2017, but fair point; I've pushed a different approach that avoids this issue.

Copy link
Member

@mdaniels5757 mdaniels5757 Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not noticing that!

Now I'm concerned, though. With this package unmaintained upstream, should we just drop this, and direct users to use the (maintained, official) libgpgmepp bindings from the gpgme package?

Copy link
Contributor Author

@samestep samestep Oct 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I have no idea; I'm still a novice Nixpkgs contributor, so I don't know what is the policy for dropping packages (I just opened this PR to try to help out with #445447). That sounds pretty reasonable to me, though.

@nixpkgs-ci nixpkgs-ci bot removed the 9.needs: reviewer This PR currently has no reviewers requested and needs attention. label Oct 25, 2025
@mdaniels5757
Copy link
Member

mdaniels5757 commented Oct 25, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455245 --build-args='-L'
Commit: 73c9f97beb620f9162a1ce77348b568ecaf880fe (subsequent changes)
Merge: fdb6647634190cfc52bf17e426a912472485c061

Logs: https://github.com/mdaniels5757/nixpkgs-review-gha/actions/runs/18805317303

x86_64-linux

✅ 1 package built:
  • libsForQt5.kf5gpgmepp (plasma5Packages.kf5gpgmepp)

aarch64-linux

✅ 1 package built:
  • libsForQt5.kf5gpgmepp (plasma5Packages.kf5gpgmepp)

x86_64-darwin

✅ No rebuilds

aarch64-darwin

✅ No rebuilds

@mdaniels5757 mdaniels5757 mentioned this pull request Oct 25, 2025
Merged
13 tasks
mdaniels5757
mdaniels5757 approved these changes Oct 25, 2025
View reviewed changes
Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just made #455601. Approving because this is good to be merged if it's decided that this package should be kept.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 25, 2025
@vcunat vcunat closed this Nov 8, 2025
@samestep samestep deleted the gpgmepp-cmake4 branch November 8, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdaniels5757 mdaniels5757 mdaniels5757 approved these changes

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samestep @mdaniels5757 @vcunat