opendungeons: fix build with cmake4#455242
Merged
Aleksanaa merged 1 commit intoNixOS:masterfrom Nov 16, 2025
Merged
Conversation
nixpkgs-ci
bot
added
10.rebuild-linux: 1-10
iedame
force-pushed
the
cmake4/opendungeons
branch
from
bc971cf to
b250346
Compare
Member
|
Contributor
Author
|
@Sigmanificient depends on #455100 |
iedame
added
the
0.kind: ZHF Fixes
PlasmaPower
approved these changes
Nov 15, 2025
Contributor
PlasmaPower
left a comment
PlasmaPower
left a comment
There was a problem hiding this comment.
LGTM. I've locally confirmed it fixes the opendungeons build when #455100 is merged in.
nixpkgs-ci
bot
added
12.approvals: 1
bryanhonof
approved these changes
Nov 16, 2025
nixpkgs-ci
bot
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #455100 to build correctly, so please test with both fixes together
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.Add a 👍 reaction to pull requests you find important.