Skip to content

libsForQt5.kdiagram: fix build with cmake 4#455240

Merged
ttuegel merged 1 commit intoNixOS:masterfrom
samestep:qt5-kdiagram-cmake4
Oct 27, 2025
Merged

libsForQt5.kdiagram: fix build with cmake 4#455240
ttuegel merged 1 commit intoNixOS:masterfrom
samestep:qt5-kdiagram-cmake4

Conversation

@samestep
Copy link
Contributor

@samestep samestep commented Oct 24, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Oct 24, 2025
@iedame iedame mentioned this pull request Oct 24, 2025
Open
@nix-owners nix-owners bot requested a review from ttuegel October 24, 2025 13:40
trueNAHO
trueNAHO approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@trueNAHO trueNAHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the build failure.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Oct 27, 2025
This was referenced Oct 27, 2025
Merged
Merged
@ttuegel ttuegel merged commit 8929c5e into NixOS:master Oct 27, 2025
31 of 33 checks passed
@samestep samestep deleted the qt5-kdiagram-cmake4 branch October 27, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ttuegel ttuegel ttuegel approved these changes

@Sigmanificient Sigmanificient Awaiting requested review from Sigmanificient

+1 more reviewer

@trueNAHO trueNAHO trueNAHO approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@samestep @ttuegel @trueNAHO