Skip to content

rpiplay: fix build with cmake4#455120

Merged
wegank merged 1 commit intoNixOS:masterfrom
iedame:cmake4/rpiplay
Oct 25, 2025
Merged

rpiplay: fix build with cmake4#455120
wegank merged 1 commit intoNixOS:masterfrom
iedame:cmake4/rpiplay

Conversation

@iedame
Copy link
Contributor

@iedame iedame commented Oct 24, 2025

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@iedame
Copy link
Contributor Author

iedame commented Oct 24, 2025

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 455120
Commit: e0445679b4407d82f3f5aca108221e960c33bb19 (subsequent changes)
Merge: 8baa4b459492a81bd874663a0c5f11d6c7d77a56

Logs: https://github.com/iedame/nixpkgs-review-gha/actions/runs/18769417518


x86_64-linux

✅ 1 package built:
  • rpiplay

aarch64-linux

✅ 1 package built:
  • rpiplay

x86_64-darwin

No rebuilds


aarch64-darwin

No rebuilds

Copy link
Member

@mdaniels5757 mdaniels5757 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff and nixpkgs-review LGTM.

@nixpkgs-ci nixpkgs-ci bot added 12.approvals: 1 This PR was reviewed and approved by one person. and removed 9.needs: reviewer This PR currently has no reviewers requested and needs attention. labels Oct 24, 2025
@wegank wegank added this pull request to the merge queue Oct 25, 2025
Merged via the queue into NixOS:master with commit 17d4470 Oct 25, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants